From owner-svn-src-all@FreeBSD.ORG Sat Jun 20 20:46:51 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B5D2CB77; Sat, 20 Jun 2015 20:46:51 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) by mx1.freebsd.org (Postfix) with ESMTP id 8F733C7C; Sat, 20 Jun 2015 20:46:50 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [192.168.1.2] (unknown [192.168.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 585B59195; Sat, 20 Jun 2015 20:46:49 +0000 (UTC) Message-ID: <5585D153.9020508@freebsd.org> Date: Sat, 20 Jun 2015 16:47:15 -0400 From: Allan Jude User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Garrett Cooper CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r284644 - head/usr.sbin/fstyp References: <201506201503.t5KF33Km091795@svn.freebsd.org> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PeSXSMQePM2gORHcGjlJDEp1t97PxbNuX" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2015 20:46:51 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PeSXSMQePM2gORHcGjlJDEp1t97PxbNuX Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2015-06-20 16:16, Garrett Cooper wrote: >=20 >> On Jun 20, 2015, at 08:03, Allan Jude wrote: >> >> Author: allanjude (doc committer) >> Date: Sat Jun 20 15:03:02 2015 >> New Revision: 284644 >> URL: https://svnweb.freebsd.org/changeset/base/284644 >> >> Log: >> Fix the build for gcc by lowering the WARNS level >> >> Approved by: sbruno >> X-MFC-With: r284589 >> >> Modified: >> head/usr.sbin/fstyp/Makefile >> >> Modified: head/usr.sbin/fstyp/Makefile >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/usr.sbin/fstyp/Makefile Sat Jun 20 13:30:09 2015 (r2846= 43) >> +++ head/usr.sbin/fstyp/Makefile Sat Jun 20 15:03:02 2015 (r2846= 44) >> @@ -11,7 +11,7 @@ SRCS +=3D zfs.c >> >> MAN=3D fstyp.8 >> >> -WARNS=3D 6 >> +WARNS?=3D 0 >=20 > You could also guard it by COMPILER_TYPE. As others have stated though,= fixing the prototypes issues is relatively trivial... >=20 This set of changes [1] allows WARNS=3D5, but 6 still has some outstandin= g issues [2] [1] https://github.com/illumos/illumos-gate/compare/master...allanjude:fix_gc= c_warnings?expand=3D1 [2] https://reviews.freebsd.org/D2045#55692 --=20 Allan Jude --PeSXSMQePM2gORHcGjlJDEp1t97PxbNuX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJVhdFZAAoJEBmVNT4SmAt+058P/RF/rBQWd40aBKlIBNPUImll Dtu6MNm8tbWwQ8d06oelXnjhWWJOGO11LP8BoL5iOWy1LZQDS+IIGU1+nNud32YB nw3yJ8emX6ZBXIL3d1xFKU9LOS84aN7ma2XZKtvzmCQtVY+qAVzYijUW+CBa/QTB nMy8lHYIrTHm66HsQKEyxvkUbFOQTHq6BXJyQBVKX9V3LVApje/lOWXd05XH6RwU M2sVcP/TzGwiYRqLoBAIahI5tpbHrGeIYBrfNl0rEMwsDGr7oUbuV69Wb36EAfYC 7MuNX35c9KuhC8OUxjDvvPhSKeDSIqU5QCPXenAm7CNMo4mTtaG8DI17g0UhBbWZ kcKQ+iy5XvxTY/YW0L4pDTuiq4R+d1tMF47Bb5IdItJWFiUkQnFJxaxE6lKw76N5 bcPk4NFjsUOTO/rKvmU+BNB42DJvL5px6JNWVuHmZxKIN6osmRGWRuNHaojr/CCK d8E+OeSl/gCy3O23J483S95L/lzcYGCMJUxNlmkTmQPJeb0OUxC28+Se3selSFlf Ex+CA64IvzUoHWxBMbeoRKkQhlDBEQXzmMAGw3nUXyukJKHUmuL4LGkfDx7kd8id SUH9glIyJe2Hc4cguXItzDwO4aPm2x0CevC6E/OrXxN+Awkd32lgJqqttQDn9jqa abeKt+w5In0yOyit9mWB =o9sb -----END PGP SIGNATURE----- --PeSXSMQePM2gORHcGjlJDEp1t97PxbNuX--