Date: Sat, 20 Nov 2010 17:40:09 GMT From: "joeb" <joeb@a1poweruser.com> To: freebsd-ports-bugs@FreeBSD.org Subject: RE: ports/148777: [New Port] sysutils/qjail: Utility to deploy large number of jails quickly Message-ID: <201011201740.oAKHe9rM022874@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/148777; it has been noted by GNATS.
From: "joeb" <joeb@a1poweruser.com>
To: <bug-followup@freebsd.org>,
<utisoft@gmail.com>
Cc:
Subject: RE: ports/148777: [New Port] sysutils/qjail: Utility to deploy large number of jails quickly
Date: Sat, 20 Nov 2010 12:30:19 -0500
Chris Rees
Thanks for the feedback.
Every thing in this port was copied from ports already in the ports system.
Even with the makefile having spaces it does install without any problems.
It does not generate any errors like you say it will.
When you talk about "redundant DISTFILES line" please be more detailed
because I cannot determine what you are referring to. Even if you think the
makefile DISTFILES= line is redundant it is not invalid and was put there as
documentation.
There are many existing ports with no distinfo so I fail to see why you
think this is an error. This was done on purpose so I can update the dist
file with fixes or enactments without having to wait for months to get the
update commented because the makesum values have changed. This technique is
communally used when the port make files will never change but allows the
maintainer to maintain the product without delays in moving updates into the
existing port.
You are incorrect, my makefile does not use ${INSTALL_DATA} it uses
do-install: and post-install:
What you call extraneous newlines in the COMMENT/MAINTAINER block, I call
visual spacing so it looks nice when shown.
If you run the port as is you will see how the "extraneous newlines" end up
presenting a professional look in the output of the installed port.
And when it comes to the messing with /etc/rc.d/jail file I was told by the
jail maintainer that he was addressing the bugs I pointed out in a up coming
release and that I should just replace it with my corrected one as part of
my port. So that is what I am doing.
Now that I have addressed all your concerns, which resulted in no changes to
the submitted port, lets get this port committed.
Thanks for your help and interest.
Joe
-----Original Message-----
From: Chris Rees [mailto:utisoft@gmail.com]
Sent: Saturday, November 20, 2010 10:40 AM
To: bug-followup@freebsd.org; joeb@a1poweruser.com
Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy
large number of jails quickly
Read the Porter's Handbook again, and look at the pointers here:
I suggest you remove the redundant DISTFILES line, and then read
http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html
Also don't use spaces in Makefiles; use tabs. That's an error.
Then read:
http://www.freebsd.org/doc/en/books/porters-handbook/rc-scripts.html
Also don't edit files not in PREFIX; you can't be messing with /etc/rc.d
Run make makesum when you're done -- you must have a distinfo
Take the & out of the COMMENT and replace it with and (you have enough
space)
Why are you using ${CP} and ${INSTALL_DATA}? Why not just the one? Also;
X ${CP} ${WRKSRC}/qjail.8 ${PREFIX}/man/man8/
X ${CP} ${WRKSRC}/qjail-intro.8 ${PREFIX}/man/man8/
X ${CP} ${WRKSRC}/qjail.conf.8 ${PREFIX}/man/man8/
you should be using ${MANPREFIX} here.
pkg-descr is quite long; and you should remove the newlines at the end
of pkg-descr
Take out the extraneous newlines in the COMMENT/MAINTAINER block.
Then run portlint -A over it (you should obviously install portlint first).
Good luck!
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011201740.oAKHe9rM022874>