From owner-svn-src-all@FreeBSD.ORG Fri Feb 13 22:25:31 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 24E0A4EC; Fri, 13 Feb 2015 22:25:31 +0000 (UTC) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0BA7837D; Fri, 13 Feb 2015 22:25:30 +0000 (UTC) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPSA id 31E6DCF892; Fri, 13 Feb 2015 14:25:24 -0800 (PST) Date: Fri, 13 Feb 2015 14:25:23 -0800 From: hiren panchasara To: Peter Holm Subject: Re: svn commit: r278623 - head/sys/kern Message-ID: <20150213222523.GD19044@strugglingcoder.info> References: <201502121331.t1CDV9jR086269@svn.freebsd.org> <20150213182901.GC19044@strugglingcoder.info> <20150213191106.GA30783@x2.osted.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="F8dlzb82+Fcn6AgP" Content-Disposition: inline In-Reply-To: <20150213191106.GA30783@x2.osted.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 22:25:31 -0000 --F8dlzb82+Fcn6AgP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 02/13/15 at 08:11P, Peter Holm wrote: > On Fri, Feb 13, 2015 at 10:29:01AM -0800, hiren panchasara wrote: > > On 02/12/15 at 01:31P, Randall Stewart wrote: > > > Author: rrs > > > Date: Thu Feb 12 13:31:08 2015 > > > New Revision: 278623 > > > URL: https://svnweb.freebsd.org/changeset/base/278623 > > >=20 > > > Log: > > > This fixes a bug I in-advertantly inserted when I updated the callo= ut > > > code in my last commit. The cc_exec_next is used to track the next > > > when a direct call is being made from callout. It is *never* used > > > in the in-direct method. When macro-izing I made it so that it > > > would separate out direct/vs/non-direct. This is incorrect and can > > > cause panics as Peter Holm has found for me (Thanks so much Peter f= or > > > all your help in this). What this change does is restore that behav= ior > > > but also get rid of the cc_next from the array and instead make it > > > be part of the base callout structure. This way no one else will get > > > confused since we will never use it for non-direct. > > > =20 > > > Reviewed by: Peter Holm and more importantly tested by him ;-) > > > MFC after: 3 days. > > > Sponsored by: Netflix Inc. > >=20 > > Can I get more info/backtraces for the panic, please? > >=20 >=20 > Sure. >=20 > These two panics were seen: >=20 > http://people.freebsd.org/~pho/stress/log/rrs004.txt > http://people.freebsd.org/~pho/stress/log/rrs005.txt Thank you, Peter. cheers Hiren --F8dlzb82+Fcn6AgP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJU3nnTXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lwnoIAIIEExjvNO8cBGXP6h+KmODm uhOTSbSLiSFwdNsZCySIWRo/HAJ0rwACKvP+1hp4YHzQfpNt8LXyELVa6hGN+Dtj 1ieRG1X0Prx7mvFjEzXlOpsDiCJ5UCs+MSn8HdJttXCRiOsCqmsdzlxRMyolahHe 3E1seziYoGoNs+0Hic2zGzso+hFDzTGtWqIMBfZPJKkRVB4tsMdYTUbMqRInpDNt jaryLhi5FvfDpyGqUMHDQB1VbWJjq9dzxK9RjAbZKdSasZOeaBV0AnvGoCenmAve rEhFYzdLNw6YSf9IjDCN2EdXYonhFk2BQapNlLSVJjVKgKI8g6YOAzOq6G2AH7M= =R9L8 -----END PGP SIGNATURE----- --F8dlzb82+Fcn6AgP--