From owner-freebsd-hackers@FreeBSD.ORG  Fri May  7 18:55:17 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 71A88106564A
	for <freebsd-hackers@freebsd.org>; Fri,  7 May 2010 18:55:17 +0000 (UTC)
	(envelope-from kaduk@mit.edu)
Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU
	[18.9.25.12]) by mx1.freebsd.org (Postfix) with ESMTP id 2D3E08FC15
	for <freebsd-hackers@freebsd.org>; Fri,  7 May 2010 18:55:16 +0000 (UTC)
X-AuditID: 1209190c-b7bd2ae000005d05-0b-4be462147f86
Received: from mailhub-auth-4.mit.edu (MAILHUB-AUTH-4.MIT.EDU [18.7.62.39])
	by dmz-mailsec-scanner-1.mit.edu (Symantec Brightmail Gateway) with
	SMTP id F0.DC.23813.41264EB4; Fri,  7 May 2010 14:55:16 -0400 (EDT)
Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
	by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id o47ItGIA020495; 
	Fri, 7 May 2010 14:55:16 -0400
Received: from multics.mit.edu (MULTICS.MIT.EDU [18.187.1.73])
	(authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU)
	by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id o47ItE3E014054
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Fri, 7 May 2010 14:55:15 -0400 (EDT)
Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308)
	id o47ItEpD026227; Fri, 7 May 2010 14:55:14 -0400 (EDT)
Date: Fri, 7 May 2010 14:55:13 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Dmitry Krivenok <krivenok.dmitry@gmail.com>
In-Reply-To: <m2ida48cf211005070159ma464fef5h5baf0107ee6e4e88@mail.gmail.com>
Message-ID: <alpine.GSO.1.10.1005071454440.29136@multics.mit.edu>
References: <m2ida48cf211005070159ma464fef5h5baf0107ee6e4e88@mail.gmail.com>
User-Agent: Alpine 1.10 (GSO 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Brightmail-Tracker: AAAAAA==
Cc: freebsd-hackers@freebsd.org
Subject: Re: Moving from FreeBSD7 to FreeBSD8 (cdev, minor, dev2unit)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 May 2010 18:55:17 -0000

On Fri, 7 May 2010, Dmitry Krivenok wrote:

>
> It looks like dev2unit is exactly what I need to fix compilation issue.
> I changed the code of all modules as follows:
>
> - int dev_num = minor(dev);
> + int dev_num = minor(dev2unit(dev));
>
> and now it compiles and works well.
>
> Is this the proper way of solving the problem?

It should be -- see the commit message for svn revision 187830 on 
2009-01-28 17:57:16Z by ed

-Ben Kaduk