Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 9 Mar 2018 04:01:26 -0500
From:      "Jason E. Hale" <jhale@freebsd.org>
To:        Yuri Victorovich <yuri@freebsd.org>
Cc:        ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r463936 - head/math/py-matplotlib
Message-ID:  <CAJE75NE41VMDygYN2MxSsA4g3ucDgRBbZp3igUOPFF1zKYi2YA@mail.gmail.com>
In-Reply-To: <201803090723.w297NjpD097376@repo.freebsd.org>
References:  <201803090723.w297NjpD097376@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 9, 2018 at 2:23 AM, Yuri Victorovich <yuri@freebsd.org> wrote:
> Author: yuri
> Date: Fri Mar  9 07:23:45 2018
> New Revision: 463936
> URL: https://svnweb.freebsd.org/changeset/ports/463936
>
> Log:
>   math/py-matplotlib: Dependency devel/py-backports.functools_lru_cache is only for python-2.7
>
>   Reported by:  tobik
>   Approved by:  tcberner (mentor, implicit)
>
> Modified:
>   head/math/py-matplotlib/Makefile
>
> Modified: head/math/py-matplotlib/Makefile
> ==============================================================================
> --- head/math/py-matplotlib/Makefile    Fri Mar  9 07:21:43 2018        (r463935)
> +++ head/math/py-matplotlib/Makefile    Fri Mar  9 07:23:45 2018        (r463936)
> @@ -19,7 +19,6 @@ LIB_DEPENDS=  libfreetype.so:print/freetype2 \
>                 libfontconfig.so:x11-fonts/fontconfig \
>                 libtcl86.so:lang/tcl86
>  RUN_DEPENDS=   ${PYNUMPY} \
> -               ${PYTHON_PKGNAMEPREFIX}backports.functools_lru_cache>0:devel/py-backports.functools_lru_cache@${FLAVOR} \
>                 ${PYTHON_PKGNAMEPREFIX}cycler>0:devel/py-cycler@${FLAVOR} \
>                 ${PYTHON_PKGNAMEPREFIX}dateutil>=1.4:devel/py-dateutil@${FLAVOR} \
>                 ${PYTHON_PKGNAMEPREFIX}pytz>=0:devel/py-pytz@${FLAVOR} \
> @@ -81,6 +80,12 @@ TKAGGBACKEND_BUILD_DEPENDS+= Xvfb:x11-servers/xorg-vfb
>  WXAGGBACKEND_BUILD_DEPENDS=    Xvfb:x11-servers/xorg-vfbserver
>  .endif
>
> +.include <bsd.port.pre.mk>
> +
> +.if ${PYTHON_REL} < 3000
> +RUN_DEPENDS+=  ${PYTHON_PKGNAMEPREFIX}backports.functools_lru_cache>0:devel/py-backports.functools_lru_cache@${FLAVOR}
> +.endif
> +
>  post-extract:
>         ${FIND} ${WRKSRC} -name \*.py | ${XARGS} ${CHMOD} -x
>
> @@ -109,4 +114,4 @@ post-install-EXAMPLES-on:
>         @${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
>         ${CP} -R ${WRKSRC}/examples/ ${STAGEDIR}${EXAMPLESDIR}
>
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
>

Instead of all the <b.p.p.m> logic, it would be a lot cleaner to just use:

py27_RUN_DEPENDS=
${PYTHON_PKGNAMEPREFIX}backports.functools_lru_cache>0:devel/py-backports.functools_lru_cache@${FLAVOR}

-Jason



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NE41VMDygYN2MxSsA4g3ucDgRBbZp3igUOPFF1zKYi2YA>