Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Nov 2002 13:07:15 -0500 (EST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Robert Watson <rwatson@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@FreeBSD.org>, Brian Feldman <green@FreeBSD.org>
Subject:   Re: PERFORCE change 21079 for review
Message-ID:  <XFMail.20021118130715.jhb@FreeBSD.org>
In-Reply-To: <Pine.NEB.3.96L.1021115191246.62811D-100000@fledge.watson.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 16-Nov-2002 Robert Watson wrote:
> On Fri, 15 Nov 2002, Brian Feldman wrote:
>>  int
>> +mac_check_system_kldload(struct ucred *cred, struct vnode *vp)
>> +{
>> +    int error;
>> +
>> +    if (vp != NULL) {
>> +            ASSERT_VOP_LOCKED(vp, "mac_check_system_acct");
>> +    }
> 
> Two questions:
> 
> (2) Looks like a copy-and-paste-o: should be kldload not acct.

__func__ > manually making copies of all function names.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021118130715.jhb>