From owner-freebsd-stable@FreeBSD.ORG  Tue Apr  1 15:41:12 2008
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C1E5F1065675
	for <freebsd-stable@freebsd.org>; Tue,  1 Apr 2008 15:41:12 +0000 (UTC)
	(envelope-from emaste@freebsd.org)
Received: from gw.sandvine.com (gw.sandvine.com [199.243.201.138])
	by mx1.freebsd.org (Postfix) with ESMTP id 40AB68FC1D
	for <freebsd-stable@freebsd.org>; Tue,  1 Apr 2008 15:41:12 +0000 (UTC)
	(envelope-from emaste@freebsd.org)
Received: from labgw2.phaedrus.sandvine.com ([192.168.3.11]) by
	gw.sandvine.com with Microsoft SMTPSVC(6.0.3790.3959); 
	Tue, 1 Apr 2008 11:40:09 -0400
Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 12627)
	id 8E94A115FF; Tue,  1 Apr 2008 11:40:09 -0400 (EDT)
Date: Tue, 1 Apr 2008 11:40:09 -0400
From: Ed Maste <emaste@freebsd.org>
To: Mike Andrews <mandrews@bit0.com>
Message-ID: <20080401154009.GA56872@sandvine.com>
References: <20080102034228.M16861@mindcrime.int.bit0.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080102034228.M16861@mindcrime.int.bit0.com>
User-Agent: Mutt/1.4.2.1i
X-OriginalArrivalTime: 01 Apr 2008 15:40:09.0775 (UTC)
	FILETIME=[AAE693F0:01C8940E]
Cc: freebsd-stable@freebsd.org
Subject: Re: aac tool regressions on 7.0-RC1
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Apr 2008 15:41:12 -0000

On Wed, Jan 02, 2008 at 03:54:50AM -0500, Mike Andrews wrote:

> On RELENG_7 dated 2007-12-15 (BETA4), aaccli fails with the following 
> error; arcconf continues to work fine:
> 
>    Command Error: <The miniport device driver is too old to work with the 
>    current AFAAPI.DLL.>

I suspect Adaptec has a firmware bug relating to the RequestAdapterInfo
and RequestSupplementAdapterInfo commands.  The driver family support
brought in the latter, while the former has always been there.  It
appears that RequestAdapterInfo returns all zeros if it's called after
RequestSupplementAdapterInfo or something.

The hack patch below forces reasonable values into the aac_revision
struct if it's zeroed, and it restores aaccli usage for me.  If you
have time I'd be interested in finding out if you can continue using
aaccli with this patch added.

-Ed

Index: aac.c
===================================================================
RCS file: /usr/cvs/src/sys/dev/aac/aac.c,v
retrieving revision 1.109.2.15
diff -p -u -r1.109.2.15 aac.c
--- aac.c       31 Mar 2008 20:03:31 -0000      1.109.2.15
+++ aac.c       1 Apr 2008 15:17:18 -0000
@@ -2792,6 +2792,13 @@ aac_describe_controller(struct aac_softc
        /* save the kernel revision structure for later use */
        info = (struct aac_adapter_info *)&fib->data[0];
        sc->aac_revision = info->KernelRevision;
+       if (sc->aac_revision.buildNumber == 0) {
+               device_printf(sc->aac_dev, "aac_revision hack\n");
+               sc->aac_revision.external.comp.major = 5;
+               sc->aac_revision.external.comp.minor = 2;
+               sc->aac_revision.external.comp.dash = 0;
+               sc->aac_revision.buildNumber = 12814;
+       }


        if (bootverbose) {