From owner-svn-src-head@freebsd.org Tue Sep 3 14:06:23 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 302D9DC68E; Tue, 3 Sep 2019 14:06:17 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zD5mZxz4PN7; Tue, 3 Sep 2019 14:06:16 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 9CC371A3F1; Tue, 3 Sep 2019 14:06:03 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 5E541CD0C; Fri, 5 Apr 2019 14:47:24 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 22E2494AEE; Fri, 5 Apr 2019 14:47:24 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 13910CD0B; Fri, 5 Apr 2019 14:47:24 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id A82B4CD03; Fri, 5 Apr 2019 14:47:21 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4BFD994AE6; Fri, 5 Apr 2019 14:47:20 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 34CCD3DC95D; Sat, 6 Apr 2019 01:47:17 +1100 (AEDT) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Ed Maste cc: "Rodney W. Grimes" , Xin LI , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs In-Reply-To: Message-ID: <20190406014249.N4174@besplex.bde.org> References: <201904050221.x352LGjU015040@repo.freebsd.org> <201904050449.x354nUEC036896@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=FNpr/6gs c=1 sm=1 tr=0 cx=a_idp_d a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=iKhvJSA4AAAA:8 a=6rpjA9K-Bi6h7L4oEakA:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 22E2494AEE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:23 -0000 X-Original-Date: Sat, 6 Apr 2019 01:47:15 +1100 (EST) X-List-Received-Date: Tue, 03 Sep 2019 14:06:23 -0000 On Fri, 5 Apr 2019, Ed Maste wrote: > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: >> > >>> +static const u_char dot_name[] = { >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; >>> +static const u_char dotdot_name[] = { >>> + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; >>> + >> >> Does it make since to encode these as hex or octal constants, >> one can not tell that those are different values in an easy >> manner. They all look like '.' in the diff, and probably >> in most editors. No, but it makes sense to write them as string constants. They are just the strings "." and ".." padded with spaces to length 11, except they are not actually strings since they are not NUL terminated. 11 is for 8+3 msdos short file names. These are not NUL terminated either, but it should be easy to ignore the extra NUL given by the string constants. > They are all either '.' or ' ', the commas are just list separators. > IMO spaces after the commas would make it slightly easier to see. The single quotes looking like commas indeed makes this hard to read. Bruce