From owner-cvs-all Fri Sep 20 8:51:16 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A4B837B401; Fri, 20 Sep 2002 08:51:15 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7503743E65; Fri, 20 Sep 2002 08:51:14 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g8KFp94v017561; Fri, 20 Sep 2002 17:51:09 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: John Baldwin Cc: Darren Reed , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c In-Reply-To: Your message of "Fri, 20 Sep 2002 11:40:59 EDT." Date: Fri, 20 Sep 2002 17:51:09 +0200 Message-ID: <17560.1032537069@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , John Baldwin writes: > >On 20-Sep-2002 Darren Reed wrote: >There is nothing intuitive about >a function named foo_length() not returning the length of 'foo'. man 9 mbuf: [...] m_length(buf, last) Return the length of the mbuf chain, and optionally a pointer to the last mbuf. [...] I'm sure there are many arguments sounding from various levels of moral altitudes about why this function is bad for the mbuf, architecture, how it spoils the youth and leads to early hair-loss in developers. Overriding all these (IMO) is the fact that N (> 3) places had implemented it in various sundry ways. That, for me, is plenty reason to make an official library function to do the job. The fact that Darren not even bothered to read the commit message, much less the man page or the code before he jumped in and botched it up, is no reason to build a historical landmark bikeshed on the spot where it happened. Over and out... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message