From owner-svn-src-all@freebsd.org Sat May 2 19:07:46 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 71F302D7941 for ; Sat, 2 May 2020 19:07:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49DzCP3YRMz4Wvr for ; Sat, 2 May 2020 19:07:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x834.google.com with SMTP id w29so10668587qtv.3 for ; Sat, 02 May 2020 12:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/yj7LphtV93g5dFmkjXes+BDHUjNvqvCs30OUsCzyN0=; b=z7ieyvZlPUOdJVHARZ/T3Fl3kIlQvCNst2EuAP0K96gMhRKR9dycWeyRcZKloq/fJA 5InmTlBu4/FQ01ax8IjKQPc3ufcH4jTJvr4avLoEh8k5qW/euK5eemfXkjAT5aM98WkW iGp65xPPawVZ3JJeIVGHKPp1/BAsC746+IaEntbCvBfK+KEqoDtAcMjVAvMp0XHoFCIA yJOBY9tO1GxtiKv1GacA9XEh92GBEVGsR721qq55hsB3rwEyYQeBNU4LN/lWMi2Y12C/ O460kRnEV9zJOByWISeE8jH9qqWFZgJhDXhv1k7s3kUSj++FUBs47AlukNQ3iVvD39Mo m2Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/yj7LphtV93g5dFmkjXes+BDHUjNvqvCs30OUsCzyN0=; b=NcT3Q51LLMaB64rLpE55ShrzzcdFsNf2A/Y07e/7nfI1MRrrQSzucon7PjSiVc3PVB I85P/AAHuwseb0bpOiWh3/obqJTbW9d/n+DpoDASOAEDqnvtZOQsto31Ac6LsVX5FHV6 vj5vU57oKWbahg4c1Lgj0EEnPUfkxi1JoBDIcUfAVcblN5+FPkdo9BeA+gqvvcTNG1aN 624jfvbn/Lp9TRjI5jlzD2gDngNgjW0MF9oxEuukKPrIqrYfGlLfVIkJzoe4ghY6wUro wSfY9qWvEASvA+X9LZNwxVkdLwTtY0YwFe34MsRk3s8rGTzZybkTi5x9WKyruSADVXA6 ywLQ== X-Gm-Message-State: AGi0PuYQRD9iSPQmk+7iO5+Ecif6rMFckR8r0f03s0uiR4V1/CiLaLl1 i7YCFz0B1IKjqWfxZGtPEwOAJkJzjQ/ir+DBFmF+mQ== X-Google-Smtp-Source: APiQypLnwbDN97zEpRznMGRkzPJDAThyzepcv7S9hJlCVrE8cdaiHFywSLEQqXRq0LGsCbDiqlnQKDAQ1cwJwNF5xDU= X-Received: by 2002:ac8:3844:: with SMTP id r4mr9462807qtb.32.1588446464207; Sat, 02 May 2020 12:07:44 -0700 (PDT) MIME-Version: 1.0 References: <202004302108.03UL8xks087664@repo.freebsd.org> <01000171d6ab14d7-e7c44f4c-9bc1-4bb4-93e0-09cc66b777e2-000000@email.amazonses.com> In-Reply-To: <01000171d6ab14d7-e7c44f4c-9bc1-4bb4-93e0-09cc66b777e2-000000@email.amazonses.com> From: Warner Losh Date: Sat, 2 May 2020 13:07:32 -0600 Message-ID: Subject: Re: svn commit: r360508 - head/sys/cam/nvme To: Colin Percival Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 49DzCP3YRMz4Wvr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=z7ieyvZl; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::834) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.02 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.02)[ip: (-9.28), ipnet: 2607:f8b0::/32(-0.33), asn: 15169(-0.43), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 May 2020 19:07:46 -0000 On Sat, May 2, 2020, 12:34 PM Colin Percival wrote: > On 2020-04-30 14:08, Warner Losh wrote: > > Author: imp > > Date: Thu Apr 30 21:08:59 2020 > > New Revision: 360508 > > URL: https://svnweb.freebsd.org/changeset/base/360508 > > > > - Unlock the periph before returning. We don't need to relock it to > > release the ccb. > > You sure about that? I'm getting a panic here: > > panic: mutex CAM device lock not owned at /usr/src/sys/cam/cam_xpt.c:3983 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfffffe00d8243430 > vpanic() at vpanic+0x182/frame 0xfffffe00d8243480 > panic() at panic+0x43/frame 0xfffffe00d82434e0 > __mtx_assert() at __mtx_assert+0xb0/frame 0xfffffe00d82434f0 > xpt_release_ccb() at xpt_release_ccb+0x30/frame 0xfffffe00d8243520 > ndaioctl() at ndaioctl+0x241/frame 0xfffffe00d8243730 > Hmmm... I'm not.. I need to figure out why... I thought I was running with invariants... Warner -- > Colin Percival > Security Officer Emeritus, FreeBSD | The power to serve > Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid >