From owner-freebsd-net Wed Oct 16 11: 7:41 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1FFA37B401; Wed, 16 Oct 2002 11:07:39 -0700 (PDT) Received: from shuttle.wide.toshiba.co.jp (shuttle.wide.toshiba.co.jp [202.249.10.124]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34E5843EB2; Wed, 16 Oct 2002 11:07:37 -0700 (PDT) (envelope-from jinmei@isl.rdc.toshiba.co.jp) Received: from localhost ([3ffe:501:100f:f::6]) by shuttle.wide.toshiba.co.jp (8.11.6/8.9.1) with ESMTP id g9GI7Ht70328; Thu, 17 Oct 2002 03:07:18 +0900 (JST) Date: Thu, 17 Oct 2002 03:07:07 +0900 Message-ID: From: JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?= To: Luigi Rizzo Cc: Sam Leffler , Julian Elischer , freebsd-arch@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: CFR: m_tag patch In-Reply-To: <20021016074610.C34626@carp.icir.org> References: <18d301c26e5e$8b5c7a30$52557f42@errno.com> <080101c27151$b2e92a30$52557f42@errno.com> <20021016074610.C34626@carp.icir.org> User-Agent: Wanderlust/2.6.1 (Upside Down) Emacs/21.2 Mule/5.0 (SAKAKI) Organization: Research & Development Center, Toshiba Corp., Kawasaki, Japan. MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Dispatcher: imput version 20000228(IM140) Lines: 33 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >>>>> On Wed, 16 Oct 2002 07:46:10 -0700, >>>>> Luigi Rizzo said: > Actually from what i have read on previous postings on this thread, > the only additional check that you might/will need is to make sure > that m_tag_cookie corresponds to the GENERIC ABI. (I re-read the thread) perhaps the example in my previous message wasn't good (and it was at least incorrect). According to the discussion on the thread, we'll probably keep m_tag_cookie being 0 and use m_tag_id in (e.g.) ip6_output.c. So, we'll be happy if this convention is kept (and will be kept) at least under netinet6. It would be good to make more explicit comments on the intended usage, not just a single comment for the m_tag_cookie member: u_int32_t m_tag_cookie; /* Module/ABI */ > Also note that in your example the code should be conditional > on __FreeBSD_version and not on __FreeBSD__ We (KAME) actually need __FreeBSD__, because we want to keep a single code base for all *BSDs (again, I know this is our local issue). But, whether or not we need __FreeBSD__ (in addition to __FreeBSD_version) is a minor point. From our point view, we do want to avoid any ifdef for separating different *BSDs. Thanks, JINMEI, Tatuya Communication Platform Lab. Corporate R&D Center, Toshiba Corp. jinmei@isl.rdc.toshiba.co.jp To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message