From owner-freebsd-bugs Wed Mar 26 03:29:41 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id DAA03864 for bugs-outgoing; Wed, 26 Mar 1997 03:29:41 -0800 (PST) Received: from lynx.europe.shiva.com (lynx.europe.shiva.com [134.191.64.5]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id DAA03858 for ; Wed, 26 Mar 1997 03:29:36 -0800 (PST) Received: from chryses.europe.shiva.com (chryses.europe.shiva.com [89.0.0.223]) by lynx.europe.shiva.com (8.8.5/8.8.5) with ESMTP id LAA27360; Wed, 26 Mar 1997 11:28:08 GMT Received: from bombus.europe.shiva.com (bombus.spider.co.uk [134.191.8.21]) by chryses.europe.shiva.com (8.8.5/8.8.5) with SMTP id LAA28012; Wed, 26 Mar 1997 11:27:54 GMT Received: by bombus.europe.shiva.com (SMI-8.6/SMI-SVR4) id LAA23855; Wed, 26 Mar 1997 11:27:54 GMT Date: Wed, 26 Mar 1997 11:27:54 GMT From: gavin@europe.shiva.com (Gavin Shearer) Message-Id: <199703261127.LAA23855@bombus.europe.shiva.com> X-Mailer: Mail User's Shell (7.2.5 10/14/92) To: matt@3am-software.com, bugs@freebsd.org Subject: Changes to if_de.c for SMC9332BDT - are they correct? Sender: owner-bugs@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Matt, I was looking at the changes in the "current" FreeBSD code to the if_de.c driver to support the new EtherPower 10/100 card. These changes seem to be the ones posted by John Capo to a news group. There is something about the changes which does not seem right. In the "tulip_boardsw_t" structure you can store four function pointers, in order: "probe", "select", "preset", and "mii_probe". The added "tulip_dc21140A_smc9332bdt_boardsw" structure has the "probe" pointing to "tulip_dc21140_smc9332_media_probe" (this is OK), but the "select" pointing to "tulip_dc21140_mii_media_preset" and the "preset" pointing to "tulip_dc21140_mii_probe". These last two seem to point to the wrong type of function. Gavin -- Gavin Shearer , Shiva Europe, +44 131 561 4219