From owner-svn-src-all@freebsd.org Sun Nov 24 21:15:10 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E25B11BC270; Sun, 24 Nov 2019 21:15:10 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47LjcG5RRhz4WCB; Sun, 24 Nov 2019 21:15:10 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f43.google.com with SMTP id z25so10840267oti.5; Sun, 24 Nov 2019 13:15:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=aQ9Chufrti8Ln+EplPSefuolSBpBS5QzAmPJXZB86t0=; b=Ghxq4s7lb4UJ+rkR+7PJ2FV3gtxpH5m3ItXatoQnongh8ck7XgeiB+MfTD6H2MtLDM HOLFaKiP09oNdw1IHcDxQccMQYAKVTR7ZDaGXXsPeM53BSoXHx3RzvoI8oDM35NJhO2A o8NW0pjgX9z6CLFVJXEHHS2Cf87BBNFnqv7JODjSs2y6kfcaoqdow4XlnbVqN6FUsU+z 6/QTru5HuXbw8d69b4CFV/qnJJjHHA6Gte8/4oCoB4RlvJxOFKDC199ALx7I+ZB0HZmy su0UznZER9+bDAwHupkdwtuJIxBM0q1INeoBwQPwUQ872bm5tN2BgZz6ENJsXsfbLXHD ILTw== X-Gm-Message-State: APjAAAWV3tgfRnEF8E4m+QPCf30mx2YVzpksXakR8bFtvShYHymDWZfs TpK71oYVrQioxBQSAQFgdT8j2rHA X-Google-Smtp-Source: APXvYqzhoCF6kt50qXJ9lYbRS5FbK0Y2/nbMRZIB/ZBG+iEUnbDR1QtZjNeAQaMPnaznkUBuIT39Tw== X-Received: by 2002:a9d:6214:: with SMTP id g20mr16695030otj.226.1574630109333; Sun, 24 Nov 2019 13:15:09 -0800 (PST) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com. [209.85.167.178]) by smtp.gmail.com with ESMTPSA id l12sm1661546oth.76.2019.11.24.13.15.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Nov 2019 13:15:09 -0800 (PST) Received: by mail-oi1-f178.google.com with SMTP id l20so11274329oie.10; Sun, 24 Nov 2019 13:15:09 -0800 (PST) X-Received: by 2002:aca:6006:: with SMTP id u6mr21082431oib.137.1574630108881; Sun, 24 Nov 2019 13:15:08 -0800 (PST) MIME-Version: 1.0 References: <201911241503.xAOF3Zqd042071@repo.freebsd.org> In-Reply-To: <201911241503.xAOF3Zqd042071@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sun, 24 Nov 2019 13:14:58 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r355055 - head/tests/sys/sys To: Li-Wen Hsu Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47LjcG5RRhz4WCB X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Nov 2019 21:15:10 -0000 Don't we already build with -fwrapv for this class of problem? The GCC docs claim that warning is only active when signed overflow is undefined. It seems that -fno-strict-overflow has similar semantics to -fwrapv, but we should probably be consistent about the flag we use. Also, if GCC is producing this warning, I think Clang needs the same flag. Best, Conrad On Sun, Nov 24, 2019 at 7:03 AM Li-Wen Hsu wrote: > > Author: lwhsu > Date: Sun Nov 24 15:03:35 2019 > New Revision: 355055 > URL: https://svnweb.freebsd.org/changeset/base/355055 > > Log: > Fix gcc build > > We have -Werror=strict-overflow so gcc complains: > > In file included from /tmp/obj/workspace/src/amd64.amd64/tmp/usr/include/bitstring.h:36:0, > from /workspace/src/tests/sys/sys/bitstring_test.c:34: > /workspace/src/tests/sys/sys/bitstring_test.c: In function 'bit_ffc_at_test': > /workspace/src/sys/sys/bitstring.h:239:5: error: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Werror=strict-overflow] > if (_start >= _nbits) { > ^ > > Disable assuming overflow of signed integer will never happen by specifying > -fno-strict-overflow > > Sponsored by: The FreeBSD Foundation > > Modified: > head/tests/sys/sys/Makefile > > Modified: head/tests/sys/sys/Makefile > ============================================================================== > --- head/tests/sys/sys/Makefile Sun Nov 24 13:53:36 2019 (r355054) > +++ head/tests/sys/sys/Makefile Sun Nov 24 15:03:35 2019 (r355055) > @@ -1,9 +1,15 @@ > # $FreeBSD$ > > +.include > + > TESTSDIR= ${TESTSBASE}/sys/sys > > ATF_TESTS_C= arb_test bitstring_test qmath_test rb_test splay_test > > WARNS?= 5 > + > +.if ${COMPILER_TYPE} == "gcc" > +CFLAGS.bitstring_test= -fno-strict-overflow > +.endif > > .include