From owner-cvs-all@FreeBSD.ORG  Mon Feb 25 10:40:47 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F30C216A403;
	Mon, 25 Feb 2008 10:40:46 +0000 (UTC) (envelope-from obrien@NUXI.org)
Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85])
	by mx1.freebsd.org (Postfix) with ESMTP id CE5BC13C457;
	Mon, 25 Feb 2008 10:40:46 +0000 (UTC) (envelope-from obrien@NUXI.org)
Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1])
	by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id m1PAekgn043660;
	Mon, 25 Feb 2008 02:40:46 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.org)
Received: (from obrien@localhost)
	by dragon.nuxi.org (8.14.2/8.14.1/Submit) id m1PAekuE043659;
	Mon, 25 Feb 2008 02:40:46 -0800 (PST) (envelope-from obrien)
Date: Mon, 25 Feb 2008 02:40:46 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Kris Kennaway <kris@FreeBSD.org>
Message-ID: <20080225104046.GA43586@dragon.NUXI.org>
References: <200802250630.m1P6UPkj035852@repoman.freebsd.org>
	<47C299C9.3030501@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47C299C9.3030501@FreeBSD.org>
X-Operating-System: FreeBSD 8.0-CURRENT
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_balloc.c
	ffs_inode.c ffs_snapshot.c ffs_softdep.c ffs_vnops.c
	src/sys/ufs/ufs ufs_bmap.c ufs_lookup.c ufs_vnops.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2008 10:40:47 -0000

On Mon, Feb 25, 2008 at 11:34:49AM +0100, Kris Kennaway wrote:
> David E. O'Brien wrote:
>> obrien      2008-02-25 06:30:24 UTC
>>   FreeBSD src repository
>>   Modified files:        (Branch: RELENG_6)
>>     sys/ufs/ffs          ffs_alloc.c ffs_balloc.c ffs_inode.c              
>>             ffs_snapshot.c ffs_softdep.c ffs_vnops.c     sys/ufs/ufs       
>>    ufs_bmap.c ufs_lookup.c ufs_vnops.c   Log:
>>   MFC: Turn most ffs 'DIAGNOSTIC's into INVARIANTS.
> 
> Didn't we (you, Ken and I) discuss that this is not a good merge
> candidate because of the possibility to introduce further spurious
> panics into a stable branch?

We agreed to let it soak for a good while.  We have not seen any new
issues for several months.  I think finding file system errors out weight
the risks due to any remaining buglets.  If one has enabled INVARIANTS,
they want to find problems in their system.

-- David