From owner-freebsd-current@freebsd.org Thu May 16 03:42:07 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0071715ABC96 for ; Thu, 16 May 2019 03:42:07 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660047.outbound.protection.outlook.com [40.107.66.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B887E87483 for ; Thu, 16 May 2019 03:42:05 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQXPR0101MB2262.CANPRD01.PROD.OUTLOOK.COM (52.132.80.151) by YQXPR0101MB2312.CANPRD01.PROD.OUTLOOK.COM (52.132.82.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Thu, 16 May 2019 03:42:03 +0000 Received: from YQXPR0101MB2262.CANPRD01.PROD.OUTLOOK.COM ([fe80::44dc:5f27:855:3fde]) by YQXPR0101MB2262.CANPRD01.PROD.OUTLOOK.COM ([fe80::44dc:5f27:855:3fde%3]) with mapi id 15.20.1900.010; Thu, 16 May 2019 03:42:03 +0000 From: Rick Macklem To: "freebsd-current@FreeBSD.org" Subject: patch that replaces a single linked list with a hash table of lists (mountd.c) for review Thread-Topic: patch that replaces a single linked list with a hash table of lists (mountd.c) for review Thread-Index: AQHVC5jY260GoM0BH0Os14CjK+Rs/Q== Date: Thu, 16 May 2019 03:42:03 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94256920-e38d-44f5-75d4-08d6d9b07619 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:YQXPR0101MB2312; x-ms-traffictypediagnostic: YQXPR0101MB2312: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 0039C6E5C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(376002)(39860400002)(346002)(136003)(189003)(199004)(52536014)(99286004)(476003)(86362001)(73956011)(2351001)(102836004)(256004)(14444005)(14454004)(46003)(2906002)(2501003)(71190400001)(66476007)(74316002)(71200400001)(6916009)(25786009)(4744005)(64756008)(66556008)(66446008)(66946007)(7696005)(5660300002)(486006)(76116006)(6506007)(53936002)(316002)(9686003)(186003)(5640700003)(55016002)(6436002)(33656002)(74482002)(786003)(68736007)(8936002)(8676002)(81156014)(81166006)(478600001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:YQXPR0101MB2312; H:YQXPR0101MB2262.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HqTkIpKewiIbXLAcCO6LmnfojOIuUact/PJTtSFP1P4LnPL3TAG61KoTXjyEMOr78sDGviVH6jtXAHmgB0RlLNmg09ioRKwii8grPO2IxPG8Wzp0z+NKUBuCcaY229HZmshGT5VszA+jnD9xde1nB9njDud2pGqPJ52OKkeughyuf6cHRbuXtyVmbFop37FoNieXNMaMCtzfLGGvbW309H6ni9BH3xlH44Hnpn/dZ8vV6HE+VlzndOGbtt3OW0Kbyn2SYXnsNvAfZ2zNx1nM0jeFDVK9rXs9RxSPwGw8OQL2YDEEfYtM3dQcj5KvKYv1azY19iQ0+etVPtMeCV4HLkCkCYvt3dj0UFKg6midvCLXpA/my+7oWvrIqZ4daZ6XeK8oexoqj9q5yeCN1aN8M/b2ga4/FNVIMwx3mVwxuIs= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 94256920-e38d-44f5-75d4-08d6d9b07619 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2019 03:42:03.7296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR0101MB2312 X-Rspamd-Queue-Id: B887E87483 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.47 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.27 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.99)[ipnet: 40.64.0.0/10(-2.69), asn: 8075(-2.20), country: US(-0.06)]; MX_GOOD(-0.01)[cached: mx2.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.97)[-0.974,0]; RCVD_IN_DNSWL_NONE(0.00)[47.66.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 May 2019 03:42:07 -0000 Hi, I just put a patch for mountd.c in phabricator as D20270, which replaces th= e single linked list of structures for exported file systems with a hash tabl= e of lists. This is part of what I hope will fix the performance of mountd when reloadi= ng the exports file(s) for a server with a lot of exported file systems. Peter Eriksson has reported that his file server with 72000+ exported file = systems takes 16sec to reload the exports file(s), which implies that the nfsd thre= ads are suspended for 16sec whenever this happens. If anyone is willing to review this patch, please do so. Thanks, rick