Date: Tue, 15 Jul 2014 09:35:20 -0600 From: Ian Lepore <ian@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r268660 - head/sys/amd64/amd64 Message-ID: <1405438520.1312.32.camel@revolution.hippie.lan> In-Reply-To: <20140715153011.GR93733@kib.kiev.ua> References: <201407150930.s6F9Uhgi052394@svn.freebsd.org> <1405432340.1312.26.camel@revolution.hippie.lan> <20140715153011.GR93733@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2014-07-15 at 18:30 +0300, Konstantin Belousov wrote:
> On Tue, Jul 15, 2014 at 07:52:20AM -0600, Ian Lepore wrote:
> > > bcopy(a_cp, b_cp, cnt);
> > > + if (__predict_false(pinned)) {
> > > + sched_unpin();
> > > + mtx_unlock(&cpage_lock);
> > > + pinned = FALSE;
> >
> > Should this pinned = FALSE be done under the cpage_lock to avoid a race?
>
> What race ? Could you describe it in more details ?
> Note that pinned is local variable.
Ahh, so it is. I just noticed that it was set under the lock and
cleared outside of the lock, and didn't look at the scope of the
variable. Sorry for the noise.
-- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1405438520.1312.32.camel>