From owner-freebsd-bugs@FreeBSD.ORG  Wed Mar  5 22:50:01 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 823FFBD5
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed,  5 Mar 2014 22:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 500F9979
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed,  5 Mar 2014 22:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s25Mo1hM084197
 for <freebsd-bugs@freefall.freebsd.org>; Wed, 5 Mar 2014 22:50:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s25Mo1gd084192;
 Wed, 5 Mar 2014 22:50:01 GMT (envelope-from gnats)
Date: Wed, 5 Mar 2014 22:50:01 GMT
Message-Id: <201403052250.s25Mo1gd084192@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: bin/187103: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Mar 2014 22:50:01 -0000

The following reply was made to PR bin/187103; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/187103: commit references a PR
Date: Wed,  5 Mar 2014 22:43:43 +0000 (UTC)

 Author: dim
 Date: Wed Mar  5 22:43:30 2014
 New Revision: 262809
 URL: http://svnweb.freebsd.org/changeset/base/262809
 
 Log:
   Pull in r203007 from upstream clang trunk:
   
     Don't produce an alias between destructors with different calling conventions.
   
     Fixes pr19007.
   
   (Please note that is an LLVM PR identifier, not a FreeBSD one.)
   
   This should fix Firefox and/or libxul crashes (due to problems with
   regparm/stdcall calling conventions) on i386.
   
   Reported by:	multiple users on freebsd-current
   PR:		bin/187103
   MFC after:	1 week
 
 Modified:
   head/contrib/llvm/tools/clang/lib/CodeGen/CGCXX.cpp
 
 Modified: head/contrib/llvm/tools/clang/lib/CodeGen/CGCXX.cpp
 ==============================================================================
 --- head/contrib/llvm/tools/clang/lib/CodeGen/CGCXX.cpp	Wed Mar  5 22:04:30 2014	(r262808)
 +++ head/contrib/llvm/tools/clang/lib/CodeGen/CGCXX.cpp	Wed Mar  5 22:43:30 2014	(r262809)
 @@ -92,7 +92,13 @@ bool CodeGenModule::TryEmitBaseDestructo
    if (!ClassLayout.getBaseClassOffset(UniqueBase).isZero())
      return true;
  
 +  // Give up if the calling conventions don't match. We could update the call,
 +  // but it is probably not worth it.
    const CXXDestructorDecl *BaseD = UniqueBase->getDestructor();
 +  if (BaseD->getType()->getAs<FunctionType>()->getCallConv() !=
 +      D->getType()->getAs<FunctionType>()->getCallConv())
 +    return true;
 +
    return TryEmitDefinitionAsAlias(GlobalDecl(D, Dtor_Base),
                                    GlobalDecl(BaseD, Dtor_Base),
                                    false);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"