From nobody Sat Apr 1 09:38:48 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PpXCz0dBfz43BMw; Sat, 1 Apr 2023 09:38:55 +0000 (UTC) (envelope-from garyj@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PpXCy40Xjz41Sj; Sat, 1 Apr 2023 09:38:54 +0000 (UTC) (envelope-from garyj@gmx.de) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680341933; i=garyj@gmx.de; bh=93p7k8tEwviJDgwqhG8uYD2s9QEb/zVbAXuKHgdfWe0=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References: Reply-To; b=XHszbjzf7I/zb51JE+FgG7mszg/JtlEoVsB3ywR8TteOW1LcvNZCL7KlITvsi9Lts pQfbJL2P2FQLCRQoufvSF2h+suzIsoRm1ybggSdcglX+RdU9dLLFLbLzNqxMDSkdxZ xIsPgootMr+AuC+MgEvSI3S9y50NbdqUgpmZUxDGTMW3eF45rGuiFK002PRETSSZ3P hW5DjJd+0wXxLKKh8hJJtT8DCtozPQwoHjoTbWpqecQs3fPj9Uvin9RzHdGyKBSKip yBapm8LAVsL6rpio0lzQBnLAr0P2gJ1HVk8qB+Z/MSdLhYhAvkZV++SguZCml8jgYb IjFjJf5bBffXw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from ernst.home ([91.59.229.34]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbRfl-1qJW8j3drl-00bpAn; Sat, 01 Apr 2023 11:38:52 +0200 Date: Sat, 1 Apr 2023 09:38:48 +0000 From: Gary Jennejohn To: Gleb Smirnoff Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 4358928e235c - main - amd64 loader: plug hard hang with serial console enabled Message-ID: <20230401113848.3dc4fd8a@ernst.home> In-Reply-To: <202303311823.32VINOlr027796@gitrepo.freebsd.org> References: <202303311823.32VINOlr027796@gitrepo.freebsd.org> Reply-To: garyj@gmx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:acWyKf4WME36x/bvj2Te3rkqaKAL7fqalrXIWq4z3nH/4nY2voF FL28smkWfb5UYWbKoGCH13SHc3M/Jt34fq/c9XYyOMP8Y2PkIWun8+ZA2FuVcap+KM29pU7 yi+kpXNWG5T6Dka7uBjbfjKO8eIDzkDFskW+YRHCnDZJAUIDalyW//q1jYxT+fBC5j3J4Tf ntrW2Zg3ZGRBO1/Cnl//g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:wmZpOGw+kcM=;JYaXa73DTYaT0X2ACAb3dy4htZm ZN+kvrZN1S/JLrNvsW1rC96JSq++4nKkxL3uNRYYxSsyqr6mC5EUQvb1VPOEjtvjUMXp6hMrm aFLaRGn2uuVMbsbfkgez0p8ZYRBjIFu4oOMKDn0NpPLw3vpkpReE097eDGGEYxizlCnmWRFwr OQB2rlRi/CYgSKyvLn0vQ2wsFdEIQvI0YH4w1OJV+RSyrD6dMtBlSTSi5cQ6hlTwW84yxHkif fGP5L+Xt+c0o/UIEOdbdvoD7uaz5vIg+n1oI3KYN8trm8M8e+NxS1ze+lHUM+G9TMagautghh URSo8oFKad1bwZu7Ac0HGYot9fRpmUfPvn1+hcQj+VpEWkzZziuZyM6TMGbIXFG7Fl0vBUHHB Ml9BqfUBDPbVZwafVYT1+LTyTJAIzgKLWLIP4tWhfFrtCDBUxbaa6ml31Jzx29pBwdms5ee1a G9D2GcNGIq6fE1pSzdH0NNahlnhDEBjyRjuKm8oyB2mF9wfGcDNUEXKY7eineONEfW1bGPHmw NJBACspEYe5vQ3oJEaeS2JxPsks/YPbmbSLO8EvHWcO9SYBEXLwsk+jI7aCwZ4O6Fh3koZPma qRvS+ovtaolxPpgwBt+cQsHy2pwELwnZAyszYDNhnK3/KHbVUleSLGbpOARnNMnxtdVJuI5ZC ahHrAzYNleZVJxlh22vwhBZxUX7uh4A6VTNSavA87d9NbbHxXM6Isn45iZwN5Lq4OXoQ+6slA TONL36Cp5NfxX6B2RkLBHjM/hRJeU1rHPINXrP4Jz94HPIA+fxr8t6WgIJLFbAihVVZClPXhk r2V4kr6J9OK1SLIQAPf+99k0bQ0DeU02jH3cgq6pxfNsldbjhbuROph72FYZJUMbuSdYa6FT4 Xdt3XqBhY2rofme409t2Wmo77LdjmMnFpsdnmy31WCVxqxv4a3Bp7IpxDt2lDX0AZJSSevaY4 zJCqpvXLQLWwLZJygTr0VAfDRzw= X-Rspamd-Queue-Id: 4PpXCy40Xjz41Sj X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Fri, 31 Mar 2023 18:23:24 GMT Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D4358928e235c1e188ad6b4650= d78bcceb225b909 > > commit 4358928e235c1e188ad6b4650d78bcceb225b909 > Author: Gleb Smirnoff > AuthorDate: 2023-03-31 18:19:25 +0000 > Commit: Gleb Smirnoff > CommitDate: 2023-03-31 18:19:25 +0000 > > amd64 loader: plug hard hang with serial console enabled > > The hang basically bricks a physical box and it can be recovered > only if you are able to boot from alternate media. This isn't a > perfect fix, but throw it in before loader experts decide on > proper one. > > Submitted by: whu > Fixes: 927358dd98cb902160093e0dc0bac002d6b43858 > --- > stand/efi/loader/efiserialio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/stand/efi/loader/efiserialio.c b/stand/efi/loader/efiserial= io.c > index 5fbc700f6ac2..0f37ef8b87dd 100644 > --- a/stand/efi/loader/efiserialio.c > +++ b/stand/efi/loader/efiserialio.c > @@ -265,6 +265,8 @@ comc_probe(struct console *sc) > */ > env =3D getenv("smbios.bios.version"); > if (env =3D=3D NULL || strncmp(env, "Hyper-V", 7) !=3D 0) { > + /* Disable being seen as "comconsole". */ > + comconsole.c_name =3D "efiserialio"; > return; > } > #endif > What if env is NULL? Shouldn't the code return without changing anything? Seems to me that this if() should be split into two if() clauses. =2D- Gary Jennejohn