Date: Tue, 27 Sep 2022 14:50:51 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 860ce9aee61a - main - security/picocrypt: Whitelist 64-bit archs Message-ID: <CAFDf7UKEx5oAN56uAAZfqoQA-%2BiwqL2EK=YOP9=uu3h2TBg%2BZg@mail.gmail.com> In-Reply-To: <YzJhmTSTQ7Sr240j@FreeBSD.org> References: <202209261903.28QJ3knH012930@gitrepo.freebsd.org> <YzJhmTSTQ7Sr240j@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000053b08305e9a8efb3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Hello Alexey,
Yes you are right, blacklist is shorter and best option to use since list
will be smaller in the future.
NOT_FOR_ARCHS=3D i386 armv6 armv7 mips powerpc powerpcspe
Coul you take a look before I commit?
Thanks,
Nuno
Alexey Dokuchaev <danfe@freebsd.org> escreveu no dia ter=C3=A7a, 27/09/2022=
=C3=A0(s)
03:36:
> On Mon, Sep 26, 2022 at 07:03:46PM +0000, Nuno Teixeira wrote:
> > commit 860ce9aee61aacd34f0b1c29d54f44dd86168835
> >
> > security/picocrypt: Whitelist 64-bit archs
>
> This is not the best approach, I'll elaborate more on this below.
>
> > - Upstream only supports 64-bit
>
> Can they be convinced to enable it again? When I first ported this
> program it definitely compiled everywhere, albeit I don't recall if
> I tried to run it on my i386 desktop.
>
> > +ONLY_FOR_ARCHS=3D amd64 arm64 mips64 powerpc64 powerpc64le riscv6=
4
> sparc64
> > +ONLY_FOR_ARCHS_REASON=3D upstream only supports 64-bit
>
> 64-bit list is more likely to change than 32-bit and is also much shorter
> (i386, arv{6,7}), so if you prefer arch limitation over fixing the bug th=
an
> NOT_FOR_ARCHS is better as it entails less churn over time. Also, suppor=
t
> for sparc64 is pretty much dropped (and even when it was kind of supporte=
d,
> we stopped building packages for it for a long time), less sure of mips64
> but I think it had been phased out in src land recently as well.
>
> ./danfe
>
--=20
Nuno Teixeira
FreeBSD Committer (ports)
--00000000000053b08305e9a8efb3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Hello Alexey,<br><br><div>Yes you are right, blacklist is =
shorter and best option to use since list will be smaller in the future.<br=
></div><div><br></div><div>NOT_FOR_ARCHS=3D i386 armv6 armv7 mips powerpc p=
owerpcspe</div><div><br></div><div>Coul you take a look before I commit?</d=
iv><div><br></div><div>Thanks,</div><div>Nuno<br></div></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Alexey Dokuchaev <=
;<a href=3D"mailto:danfe@freebsd.org">danfe@freebsd.org</a>> escreveu no=
dia ter=C3=A7a, 27/09/2022 =C3=A0(s) 03:36:<br></div><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex">On Mon, Sep 26, 2022 at 07:03:46PM +0000, Nuno=
Teixeira wrote:<br>
> commit 860ce9aee61aacd34f0b1c29d54f44dd86168835<br>
> <br>
>=C2=A0 =C2=A0security/picocrypt: Whitelist 64-bit archs<br>
<br>
This is not the best approach, I'll elaborate more on this below.<br>
<br>
>=C2=A0 =C2=A0- Upstream only supports 64-bit<br>
<br>
Can they be convinced to enable it again?=C2=A0 When I first ported this<br=
>
program it definitely compiled everywhere, albeit I don't recall if<br>
I tried to run it on my i386 desktop.<br>
<br>
> +ONLY_FOR_ARCHS=3D=C2=A0 =C2=A0 =C2=A0 amd64 arm64 mips64 powerpc64 po=
werpc64le riscv64 sparc64<br>
> +ONLY_FOR_ARCHS_REASON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0upstream only supp=
orts 64-bit<br>
<br>
64-bit list is more likely to change than 32-bit and is also much shorter<b=
r>
(i386, arv{6,7}), so if you prefer arch limitation over fixing the bug than=
<br>
NOT_FOR_ARCHS is better as it entails less churn over time.=C2=A0 Also, sup=
port<br>
for sparc64 is pretty much dropped (and even when it was kind of supported,=
<br>
we stopped building packages for it for a long time), less sure of mips64<b=
r>
but I think it had been phased out in src land recently as well.<br>
<br>
./danfe<br>
</blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nun=
o Teixeira<br>FreeBSD Committer (ports)</span></div></div>
--00000000000053b08305e9a8efb3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKEx5oAN56uAAZfqoQA-%2BiwqL2EK=YOP9=uu3h2TBg%2BZg>