From owner-cvs-src@FreeBSD.ORG  Mon Dec  3 17:47:51 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 76FA416A41A;
	Mon,  3 Dec 2007 17:47:51 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179])
	by mx1.freebsd.org (Postfix) with ESMTP id 4292C13C44B;
	Mon,  3 Dec 2007 17:47:51 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (localhost [127.0.0.1])
	by VARK.MIT.EDU (8.14.2/8.14.1) with ESMTP id lB3HljCb013653;
	Mon, 3 Dec 2007 12:47:45 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.MIT.EDU (8.14.2/8.14.1/Submit) id lB3HljLj013652;
	Mon, 3 Dec 2007 12:47:45 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Date: Mon, 3 Dec 2007 12:47:45 -0500
From: David Schultz <das@FreeBSD.ORG>
To: Andrey Chernov <ache@nagual.pp.ru>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Message-ID: <20071203174745.GA13567@VARK.MIT.EDU>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
References: <200712030718.lB37IlLc009328@repoman.freebsd.org>
	<20071203072214.GA11030@VARK.MIT.EDU>
	<20071203080739.GA56795@nagual.pp.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071203080739.GA56795@nagual.pp.ru>
Cc: 
Subject: Re: cvs commit: src/tools/regression/lib/libc/stdio
	test-printfloat.c test-scanfloat.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2007 17:47:51 -0000

On Mon, Dec 03, 2007, Andrey Chernov wrote:
> On Mon, Dec 03, 2007 at 02:22:14AM -0500, David Schultz wrote:
> > On Mon, Dec 03, 2007, David Schultz wrote:
> > > das         2007-12-03 07:18:47 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     tools/regression/lib/libc/stdio test-printfloat.c 
> > >                                     test-scanfloat.c 
> > >   Log:
> > >   Tests for rounding, and for the leading 0's bug.
> > 
> > test-printfloat is failing on my machine due to the fact that the
> > default locale in FreeBSD seems to have a thousands separator now.
> > I thought the default locale wasn't supposed to. Can someone
> > comment?
> 
> Default locale don't have thousands separator as you can see:
> 
> static const struct lc_numeric_T _C_numeric_locale = {
>         ".",            /* decimal_point */
>         "",             /* thousands_sep */
>         numempty        /* grouping */
> };
> 
> Something wrong in your default locale setup, use LC_ALL=C for sure.

This works, but there's still something wrong, because the start
of the program has a line:

        assert(setlocale(LC_NUMERIC, ""));

It looks like it should be setlocale(LC_NUMERIC, "C") to ensure
that the right locale is used. I'll go ahead and fix that.