From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Mar 21 14:10:03 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18B2F10656E1 for ; Sat, 21 Mar 2009 14:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E79D08FC2C for ; Sat, 21 Mar 2009 14:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2LEA2i1032578 for ; Sat, 21 Mar 2009 14:10:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n2LEA2F0032577; Sat, 21 Mar 2009 14:10:02 GMT (envelope-from gnats) Resent-Date: Sat, 21 Mar 2009 14:10:02 GMT Resent-Message-Id: <200903211410.n2LEA2F0032577@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henry Karpatskij Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 654EA106566C for ; Sat, 21 Mar 2009 14:05:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 540CF8FC13 for ; Sat, 21 Mar 2009 14:05:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2LE5Smq093966 for ; Sat, 21 Mar 2009 14:05:28 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n2LE5S6R093965; Sat, 21 Mar 2009 14:05:28 GMT (envelope-from nobody) Message-Id: <200903211405.n2LE5S6R093965@www.freebsd.org> Date: Sat, 21 Mar 2009 14:05:28 GMT From: Henry Karpatskij To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/132905: security/oidentd build faild on 8.0-CURRENT X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2009 14:10:03 -0000 >Number: 132905 >Category: ports >Synopsis: security/oidentd build faild on 8.0-CURRENT >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Mar 21 14:10:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Henry Karpatskij >Release: 8.0-CURRENT >Organization: >Environment: FreeBSD flame.spheroid.fi 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Fri Mar 20 10:57:47 EET 2009 henkka@flame.spheroid.fi:/usr/obj/usr/src/sys/FLAME sparc64 >Description: Build fails with: if cc -DHAVE_CONFIG_H -I. -I. -I.. "-Imissing" -funsigned-char -O2 -pipe -fno-strict-aliasing -MT oidentd.o -MD -MP -MF ".deps/oidentd.Tpo" -c -o oidentd.o oidentd.c; then mv -f ".deps/oidentd.Tpo" ".deps/oidentd.Po"; else rm -f ".deps/oidentd.Tpo"; exit 1; fi ./oidentd_util.h:61: error: nested function 'randval' declared but never defined *** Error code 1 >How-To-Repeat: Just "make". >Fix: Change the randval function to be non-inline. My C-skills are pretty limited so there might a be a Better Way to do it. Patch included, though. Patch attached with submission follows: diff -ur work/oidentd-2.0.8/src/oidentd_util.c work/oidentd-2.0.8-non-inline/src/oidentd_util.c --- work/oidentd-2.0.8/src/oidentd_util.c 2009-03-21 16:04:09.000000000 +0200 +++ work/oidentd-2.0.8-non-inline/src/oidentd_util.c 2009-03-21 16:05:54.000000000 +0200 @@ -75,7 +75,7 @@ ** PRNG functions on systems whose libraries provide them.) */ -inline int randval(int i) { +int randval(int i) { /* Per _Numerical Recipes in C_: */ return ((double) i * rand() / (RAND_MAX+1.0)); } diff -ur work/oidentd-2.0.8/src/oidentd_util.h work/oidentd-2.0.8-non-inline/src/oidentd_util.h --- work/oidentd-2.0.8/src/oidentd_util.h 2009-03-21 16:04:21.000000000 +0200 +++ work/oidentd-2.0.8-non-inline/src/oidentd_util.h 2009-03-21 16:05:54.000000000 +0200 @@ -58,7 +58,7 @@ int find_group(const char *temp_group, gid_t *gid); int random_seed(void); -inline int randval(int i); +int randval(int i); #ifndef HAVE_SNPRINTF int snprintf(char *str, size_t n, char const *fmt, ...); >Release-Note: >Audit-Trail: >Unformatted: