From owner-svn-src-head@freebsd.org Mon Apr 10 18:10:13 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBAA0D37F09; Mon, 10 Apr 2017 18:10:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B871E378; Mon, 10 Apr 2017 18:10:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 8A79F10A82D; Mon, 10 Apr 2017 14:10:05 -0400 (EDT) From: John Baldwin To: Jung-uk Kim Cc: Patrick Kelsey , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316648 - in head/sys: amd64/amd64 amd64/include arm/arm arm/include arm64/include cddl/dev/dtrace/aarch64 cddl/dev/dtrace/amd64 cddl/dev/dtrace/arm cddl/dev/dtrace/i386 cddl/dev/dtrace... Date: Mon, 10 Apr 2017 10:43:12 -0700 Message-ID: <3233183.B722KJrnTC@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <0da40261-7829-8d63-c4aa-775a028367a2@FreeBSD.org> References: <201704090200.v39203Vf072867@repo.freebsd.org> <0da40261-7829-8d63-c4aa-775a028367a2@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 10 Apr 2017 14:10:05 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 18:10:14 -0000 On Monday, April 10, 2017 01:23:04 PM Jung-uk Kim wrote: > On 04/08/2017 22:00, Patrick Kelsey wrote: > > Author: pkelsey > > Date: Sun Apr 9 02:00:03 2017 > > New Revision: 316648 > > URL: https://svnweb.freebsd.org/changeset/base/316648 > > > > Log: > > Corrected misspelled versions of rendezvous. > > > > The MFC will include a compat definition of smp_no_rendevous_barrier() > > that calls smp_no_rendezvous_barrier(). > > > > Reviewed by: gnn, kib > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D10313 > ... > > We knew about the problem but we didn't fix it because it breaks KPI. > For example, sysutils/virtualbox-ose-kmod. If you really want to MFC > this change, you have to implement shims. Also, the function isn't actually called, but is only used in comparisons in smp_rendezvous_action(). To do a compat shim you will need to either change these comparisons to compare against both function pointers or define the alternate symbol as an alias of the existing function. That only helps the KBI though. For the KPI would just use a #define to point to the new name. Also, as Jung-uk notes, this already breaks virtualbox on HEAD, so you will need to patch the port now, not only if you MFC. -- John Baldwin