From owner-freebsd-net@FreeBSD.ORG Fri Jun 12 17:50:07 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 473211065672 for ; Fri, 12 Jun 2009 17:50:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3]) by mx1.freebsd.org (Postfix) with ESMTP id 0176B8FC1F for ; Fri, 12 Jun 2009 17:50:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 4BECF41C795; Fri, 12 Jun 2009 19:50:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([195.88.108.3]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id 17Yt36L9yzNO; Fri, 12 Jun 2009 19:50:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id CB98A41C75A; Fri, 12 Jun 2009 19:50:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id F3AEF4448E6; Fri, 12 Jun 2009 17:45:57 +0000 (UTC) Date: Fri, 12 Jun 2009 17:45:57 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Andrew Gallatin In-Reply-To: <4A325883.3050206@cs.duke.edu> Message-ID: <20090612174248.X22887@maildrop.int.zabbadoz.net> References: <20090611184555.J22887@maildrop.int.zabbadoz.net> <4A325883.3050206@cs.duke.edu> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: FreeBSD net mailing list Subject: Re: Ethernet NIC drivers depending unconditionally on INET X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2009 17:50:07 -0000 On Fri, 12 Jun 2009, Andrew Gallatin wrote: Hi, > Bjoern A. Zeeb wrote: > >> if_mxge: >> ---------------------------------------- >> mxge_rx_csum() has one in_pseudo(). The function and callers >> already seem to know how do deal with results in case the csum can't >> be validated. So this should be a simple #ifdef INET wrapping here; >> side note: the tcpudp_csum variables in the callers are not needed. >> side note: huge inlining going on there;) >> mxge_lro_flush() has another call to in_pseudo(). As with if_igb/ixgbe > > Thanks for pointing those out. It will be a few days before > I've got time to deal with it properly. If you don't see > me commit a fix within a week, please remind me. Well do not rush it; it's been like that for ages; we may first want to get infrastructure etc. in place to better fix all those maybe? It's just that it won't be forgotten in 3 months;-) >> if there is no INET there should be no LRO for now, the capabilities >> not advertised, etc. Be prepared in case LRO will arrive for IPv6. > > As to LRO & IPV6... I was going to port our LRO for IPv6, > but discovered the state of IPv6 in FreeBSD is so disgraceful > that there was no point. Eg, there is no checksum offload, > no TSO, etc, for INET6. Once those things are there, I'll > be happy to provide LRO for IPv6. With "port our LRO" you mean the driver parts? So how much does the FreeBSD infrastructure for LRO/v4 help and work for you (and the others)? Would adding v6 support there help? I will have to have a look but I can work on those things (propably post-RC1 or so). Till then a few other things still need my attention. /bz -- Bjoern A. Zeeb The greatest risk is not taking one.