From owner-freebsd-net@FreeBSD.ORG  Sat Jun 13 19:39:58 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E437FC80
 for <freebsd-net@hub.freebsd.org>; Sat, 13 Jun 2015 19:39:58 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CE7F6351
 for <freebsd-net@FreeBSD.org>; Sat, 13 Jun 2015 19:39:58 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5DJdw4G084080
 for <freebsd-net@FreeBSD.org>; Sat, 13 Jun 2015 19:39:58 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-net@FreeBSD.org
Subject: [Bug 200323] BPF userland misuse can crash the system
Date: Sat, 13 Jun 2015 19:39:59 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 10.1-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: eri@pfsense.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-200323-2472-PbgXKKToUA@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-200323-2472@https.bugs.freebsd.org/bugzilla/>
References: <bug-200323-2472@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jun 2015 19:39:59 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200323

--- Comment #1 from Ermal Lu=C3=A7i <eri@pfsense.org> ---
This patch fixes the issue and the issue seems to a locked LLE which does n=
ot
allow BPF to sleep when it needs to.

+diff --git a/sys/netinet/if_ether.c b/sys/netinet/if_ether.c
+index baa9c26..f31576d 100644
+--- a/sys/netinet/if_ether.c
++++ b/sys/netinet/if_ether.c
+@@ -353,6 +353,10 @@ retry:
+     if ((la->la_flags & LLE_VALID) &&
+         ((la->la_flags & LLE_STATIC) || la->la_expire > time_uptime)) {
+         bcopy(&la->ll_addr, desten, ifp->if_addrlen);
++        if (flags & LLE_EXCLUSIVE)
++            LLE_WUNLOCK(la);
++        else
++            LLE_RUNLOCK(la);
+         /*
+          * If entry has an expiry time and it is approaching,
+          * see if we need to send an ARP request within this
+@@ -365,8 +369,7 @@ retry:
+         }
+=20
+         *lle =3D la;
+-        error =3D 0;
+-        goto done;
++        return (0);
+     }
+=20
+     if (la->la_flags & LLE_STATIC) {   /* should not happen! */

--=20
You are receiving this mail because:
You are the assignee for the bug.=