From owner-svn-ports-head@freebsd.org Thu Jan 31 14:20:31 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B333F14AB3CA; Thu, 31 Jan 2019 14:20:31 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5857690A8C; Thu, 31 Jan 2019 14:20:31 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 068F834C3; Thu, 31 Jan 2019 14:20:31 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f180.google.com with SMTP id k15-v6so2811010ljc.8; Thu, 31 Jan 2019 06:20:30 -0800 (PST) X-Gm-Message-State: AJcUukcgUUYRrOJuvX5274cFr+Qk6bim7nzqP4KfC+yaC8R0yXWE35wV NtSGVK4CijIGXB0AqDTgQnPcXcDNEpLAM8gECps= X-Google-Smtp-Source: ALg8bN729gRrBHoPz+NP0vBDzmsH/Bqllq+o+Wg+Cf78yzcCHf07q7LQXRrgZcyeRLK+gagD4Lg0codIL9Ax1VnlAQk= X-Received: by 2002:a2e:710a:: with SMTP id m10-v6mr27366722ljc.66.1548944429451; Thu, 31 Jan 2019 06:20:29 -0800 (PST) MIME-Version: 1.0 References: <201901310204.x0V24U5Y032910@repo.freebsd.org> <20190131021439.GA94120@FreeBSD.org> <20190131133732.GA76004@night.db.net> <20190131140956.GA93408@FreeBSD.org> In-Reply-To: <20190131140956.GA93408@FreeBSD.org> From: Kyle Evans Date: Thu, 31 Jan 2019 08:19:48 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r491675 - in head/comms/fldigi: . files To: Alexey Dokuchaev Cc: Diane Bruce , svn-ports-head@freebsd.org, Diane Bruce , svn-ports-all@freebsd.org, ports-committers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5857690A8C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.932,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 14:20:31 -0000 On Thu, Jan 31, 2019 at 8:10 AM Alexey Dokuchaev wrote: > > On Thu, Jan 31, 2019 at 08:37:32AM -0500, Diane Bruce wrote: > > On Thu, Jan 31, 2019 at 02:14:39AM +0000, Alexey Dokuchaev wrote: > > > ... > > > These two patches were essentially not changed and should have been > > > dropped from the commit batch to reduce repo churn and diff noise. > > > > Tell that to the make makepatch maintainers please. > > Well, no: makepatch would never (and it's not supposed to) be so smart > to detect/mitigate these things. Evaluating a diff (and commit hygiene > in general) is committer's responsibility. > It's worth noting that I added some bits [1] to makepatch to try and help reduce some churn by blatantly ignoring new patches that resulted in only change to the timestamp. I think there's no reason this couldn't grow the ability to ignore changes like the ones you pointed out if you make sure it's still sensitive to the line offset information -- I think we should be making some level of effort to keep line numbers reflective of the current code-base to minimize effort required in identifying the block and verifying correctness of the patch. Thanks, Kyle Evans [1] https://svnweb.freebsd.org/ports?view=revision&revision=459675