From owner-freebsd-fs@FreeBSD.ORG Fri May 30 06:54:44 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5973D106566B for ; Fri, 30 May 2008 06:54:44 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206046210.chello.pl [87.206.46.210]) by mx1.freebsd.org (Postfix) with ESMTP id BF5A68FC1B for ; Fri, 30 May 2008 06:54:43 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 6A99545C9F; Fri, 30 May 2008 08:54:42 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 945C44569A; Fri, 30 May 2008 08:54:38 +0200 (CEST) Date: Fri, 30 May 2008 08:54:39 +0200 From: Pawel Jakub Dawidek To: Niki Denev Message-ID: <20080530065439.GB3596@garage.freebsd.pl> References: <2e77fc10802120304n32fd1c42m52e6bc617ba07c35@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l76fUT7nc3MelDdI" Content-Disposition: inline In-Reply-To: <2e77fc10802120304n32fd1c42m52e6bc617ba07c35@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org Subject: Re: ZFS panic when changing zfs dataset mountpoint X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 May 2008 06:54:44 -0000 --l76fUT7nc3MelDdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 12, 2008 at 01:04:38PM +0200, Niki Denev wrote: > Hi, >=20 > I got the following panic when trying to set/change the mountpoint > property of a dataset. >=20 > I did : > # zfs set mountpoint=3D/usr/ports zfs2/ports > and the machine crashed. >=20 > The datased had one snapshot taken. >=20 > Here is what i was able to extract from the dump : [...] > #8 0xffffffff804800d5 in _sx_xlock (sx=3D0xa0, opts=3D0, > file=3D0xffffffff80c697f0 > "/usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/zfs/zfs= _ctldir.c", > line=3D1069) at atomic.h:142 > #9 0xffffffff80c50b2a in zfsctl_umount_snapshots (vfsp=3DVariable > "vfsp" is not available. > ) at /usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/zfs= /zfs_ctldir.c:1069 > #10 0xffffffff80c57978 in zfs_umount (vfsp=3D0xffffff00014f5650, > fflag=3D0, td=3D0xffffff001483b6a0) > at /usr/src/sys/modules/zfs/../../contrib/opensolaris/uts/common/fs/z= fs/zfs_vfsops.c:692 [...] I tried to reproduce your problem, but I can't. This is clearly related to unmounting snapshots. Was your snapshot mounted at the time of calling 'zfs set mountpoint=3D'? I tried both scenarious (having mounted and unmounted snapshot) and no panic. Is there anything else you did? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --l76fUT7nc3MelDdI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIP6SuForvXbEpPzQRAl4iAJ9ypW2a5yLlAATkO9iJ/X+mAmNjuwCcCj1Q BWoKpnxopLFFHDAMf92rXEc= =Nhw6 -----END PGP SIGNATURE----- --l76fUT7nc3MelDdI--