From owner-freebsd-ports@FreeBSD.ORG Wed Feb 9 13:43:21 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 44BF0106564A for ; Wed, 9 Feb 2011 13:43:21 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 052A88FC08 for ; Wed, 9 Feb 2011 13:43:20 +0000 (UTC) Received: by vws9 with SMTP id 9so95319vws.13 for ; Wed, 09 Feb 2011 05:43:20 -0800 (PST) Received: by 10.220.175.139 with SMTP id ba11mr2206594vcb.145.1297258999135; Wed, 09 Feb 2011 05:43:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.184.12 with HTTP; Wed, 9 Feb 2011 05:42:58 -0800 (PST) In-Reply-To: References: From: Sunpoet Hsieh Date: Wed, 9 Feb 2011 21:42:58 +0800 Message-ID: To: arrowdodger <6yearold@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2011 13:43:21 -0000 On Wed, Feb 9, 2011 at 5:15 PM, arrowdodger <6yearold@gmail.com> wrote: > On Tue, Feb 8, 2011 at 9:29 PM, Sunpoet Hsieh wrote= : >> >> Hi, >> >> First of all, I suggest to set PORTNAME=3Dtortoisehg >> If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=3D-hgtk >> instead. >> It makes portlint happier. >> It also simplifies Makefile since DISTNAME is already the default value. > > Well, i added -hgtk because TortoiseHG 2.0 (which will be released at Mar= ch) > will be using PyQT, but current GTK version will be supported as long as = it > is used. So, user will be able to choose between hgtk if he prefers GTK o= r > pyqt if he likes Qt. It is not an option for a port, but two different > programs and they can be installed simultaneously. > Maybe the port itself should be called tortoisehg-hgtk? > It looks like you'll have two ports, version 1 and 2, and these two ports do not conflict with each other. IMHO, I would simply use devel/tortoisehg1 for version 1 and devel/tortoisehg for upcoming version 2. You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK or = Qt. >> In your case, it can be done without extra patch files. >> >> .if !defined(WITH_NAUTILUS) >> =C2=A0 =C2=A0 =C2=A0 =C2=A0@${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${= PYSETUP} >> .endif >> .if !defined(WITH_NLS) >> =C2=A0 =C2=A0 =C2=A0 =C2=A0@${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${= PYSETUP} >> .endif > > That's definetely nicer than any patches. > >> Here, I suggest a shorter option name "NAUTILUS" instead of >> "NAUTILUS_EXTENSION". >> Also, for PLIST_SUB, I think "NLS" is OK for most ports. >> >> .if !defined(WITH_NLS) >> PLIST_SUB+=3D =C2=A0 =C2=A0 NLS=3D"@comment " >> .else >> PLIST_SUB+=3D =C2=A0 =C2=A0 NLS=3D"" >> .endif > > Will do. > >> >> > 2. The port also installs *.egg-info file and i'm not sure how to >> > include it >> > in the plist. >> >> You should set PYDISTUTILS_EGGINFO=3D. >> bsd.python.mk will add them to PLIST automatically. >> >> PYDISTUTILS_EGGINFO defaults to tortoisehg-1.1.9.1-py2.6.egg-info. >> (when PORTNAME=3Dtortoisehg) > > What if PORTNAME!=3Dtortoisehg? I mean, if i'm setting PYDISTUTILS_EGGINF= O, > where should i obtain that -py2.6- part? PYDISTUTILS_EGGINFO defaults to ${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/[^A-= Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info (Mk/bsd.python.mk, around line 509) For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_VER. (Mk/bsd.python.mk, around line 372-410) --=20 =C2=A0 Sunpoet Po-Chuan Hsieh =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B = 8CC0 DC44 247E CC57 E36B =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 http://people.FreeBSD.org/~sunpoet/pgpkeys.txt