Date: Fri, 12 Feb 2021 19:19:24 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Message-ID: <bug-253158-3630-OmZr4ahFQ3@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-253158-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-253158-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #12 from Harald Schmalzbauer <bugzilla.freebsd@omnilan.de> --- (In reply to Harald Schmalzbauer from comment #11) To be precise, I didn't apply the commit (8563de2f2799) but the attachment here, which results in the following diff between main-patch and pr-patch: +++ /opt/deploy-tools/FreeBSD-src/stable_13/sys/ufs/ffs/ffs_snapshot.c=20 2021-02-12 20:05:44.560632000 +0100 @@ -532,7 +532,7 @@ * in the direct blocks, but we add the slop for them in case * they do not end up there. The snapshot list size may get * expanded by one because of an update of an inode block for - * an unlinked but still open files when it is expunged. + * an unlinked but still open file when it is expunged. * * Because the direct block pointers are always copied, they * are not added to the list. Instead ffs_copyonwrite() @@ -723,7 +723,7 @@ free(copy_fs, M_UFSMNT); copy_fs =3D NULL; } - KASSERT(error !=3D 0 || (error =3D=3D 0 && sn !=3D NULL && copy_fs = !=3D NULL), + KASSERT(error !=3D 0 || (sn !=3D NULL && copy_fs !=3D NULL), ("missing snapshot setup parameters")); /* * Resume operation on filesystem. To my limited knowledge, this can't be the root caus of my panic. stable/13 is missing two commits from kib@ for ffs_snapshot.c, but I'm quite sure that these don't affect the changes here. Compiling a kernel with verified sources and actual 8563de2f2799 applied... Meanwhile trying to find something I could run main on... --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253158-3630-OmZr4ahFQ3>