From owner-svn-soc-all@FreeBSD.ORG Tue Jul 9 05:39:11 2013 Return-Path: Delivered-To: svn-soc-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3802FDA1 for ; Tue, 9 Jul 2013 05:39:11 +0000 (UTC) (envelope-from mattbw@FreeBSD.org) Received: from socsvn.freebsd.org (socsvn.freebsd.org [IPv6:2001:1900:2254:206a::50:2]) by mx1.freebsd.org (Postfix) with ESMTP id 2AB4818E2 for ; Tue, 9 Jul 2013 05:39:11 +0000 (UTC) Received: from socsvn.freebsd.org ([127.0.1.124]) by socsvn.freebsd.org (8.14.7/8.14.7) with ESMTP id r695dBpX012448 for ; Tue, 9 Jul 2013 05:39:11 GMT (envelope-from mattbw@FreeBSD.org) Received: (from www@localhost) by socsvn.freebsd.org (8.14.7/8.14.6/Submit) id r695dBR2012445 for svn-soc-all@FreeBSD.org; Tue, 9 Jul 2013 05:39:11 GMT (envelope-from mattbw@FreeBSD.org) Date: Tue, 9 Jul 2013 05:39:11 GMT Message-Id: <201307090539.r695dBR2012445@socsvn.freebsd.org> X-Authentication-Warning: socsvn.freebsd.org: www set sender to mattbw@FreeBSD.org using -f From: mattbw@FreeBSD.org To: svn-soc-all@FreeBSD.org Subject: socsvn commit: r254446 - soc2013/mattbw/backend MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-soc-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the entire Summer of Code repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jul 2013 05:39:11 -0000 Author: mattbw Date: Tue Jul 9 05:39:10 2013 New Revision: 254446 URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=254446 Log: even more static analysis cleanup Modified: soc2013/mattbw/backend/groups.c Modified: soc2013/mattbw/backend/groups.c ============================================================================== --- soc2013/mattbw/backend/groups.c Tue Jul 9 05:35:36 2013 (r254445) +++ soc2013/mattbw/backend/groups.c Tue Jul 9 05:39:10 2013 (r254446) @@ -27,10 +27,10 @@ #include "groups.h" /* prototypes */ #include "mappings.h" /* mapping macros */ -const char ORIGIN_SEPARATOR = '/'; +static const char ORIGIN_SEPARATOR = '/'; struct group_mapping { - const char *key; + const char /* @null@ */ *key; PkGroupEnum group; }; @@ -131,10 +131,10 @@ /* Maps from port/origin directories to PackageKit groups. */ PkGroupEnum -group_from_port_dir(const char *port_dir) +group_from_port_dir( /* @null@ */ const char *port_dir) { struct group_mapping *result; - + MAPPING_FIND(port_dir, &result, group_mappings); return result->group; }