From owner-svn-src-all@freebsd.org Mon Jan 11 05:19:35 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2BD5A6BE1C; Mon, 11 Jan 2016 05:19:35 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com [IPv6:2607:f8b0:4003:c01::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A5D0141A; Mon, 11 Jan 2016 05:19:35 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-ob0-x234.google.com with SMTP id py5so22653354obc.2; Sun, 10 Jan 2016 21:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=nJbcoehgebAgWBRohuRUPWMtUiwrVbId66Mj0jww1gY=; b=Rcq5m2Yr1gg1KCrYgbpmYVxiJAZbWrW5rETekyW6reENIQGHCbplrx2WIsYmTxE9yA Zin7XuA5kPB1WBgbT4I2HUt/XlqdxHozGaxSSHilnE4xG/MKCwwVn+KcBnswKtzeJwoq IBszOKVRfJ/N1mZNUR4BEJQp9c1Dyu2voYYKUA8ELd+biXQOQ3Fr6pKdOSiY5HDv4fy2 j6trvEoUWVtuBRLIQSLQ0CTEPJzMG5bLto2qOGl9LgDf/JJlw3eOGfeFVtTtkCylUJvI 9VLiEn7Rbjp7LG86UiijarL2Nt0X6ieEh8uaEF/hz4wV0Vam6bZpWsTg2q7vm6WtBO/7 YNqw== MIME-Version: 1.0 X-Received: by 10.182.49.170 with SMTP id v10mr90146126obn.64.1452489574798; Sun, 10 Jan 2016 21:19:34 -0800 (PST) Received: by 10.182.40.194 with HTTP; Sun, 10 Jan 2016 21:19:34 -0800 (PST) Reply-To: araujo@FreeBSD.org In-Reply-To: <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> References: <201512271812.tBRICD3A044563@repo.freebsd.org> <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> Date: Mon, 11 Jan 2016 13:19:34 +0800 Message-ID: Subject: Re: svn commit: r292788 - in head/sys: geom/part sys From: Marcelo Araujo To: Ravi Pokala Cc: Allan Jude , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2016 05:19:35 -0000 IMHO, if it can't be something generic that other people can use it, it is a NO GO! -1 2016-01-11 12:54 GMT+08:00 Ravi Pokala : > Hi folks, > > I have a Panasas-proprietary GPT UUID that I'd like to commit upstream. > There's ~zero chance anyone outside of Panasas or our customers would ever > see it, but we're trying to reduce gratuitous differences against upstream, > and this is a good candidate. When I mentioned this at the November 2015 > DevSummit, no one there objected. > > There was a recent change in this area, which brought up some questions. > See below: > > -----Original Message----- > > > From: on behalf of Allan Jude > > Date: 2015-12-27, Sunday at 10:12 > To: , , < > svn-src-head@freebsd.org> > Subject: svn commit: r292788 - in head/sys: geom/part sys > > >Author: allanjude > >Date: Sun Dec 27 18:12:13 2015 > >New Revision: 292788 > >URL: https://svnweb.freebsd.org/changeset/base/292788 > > > >Log: > > Add some additional GPT partition types > > > >... > > > > Differential Revision: https://reviews.freebsd.org/D3841 > > > >... > > > > In that review, there was discussion about the sorting of aliases in (enum > g_part_alias). It was originally thought that the aliases needed to be > sorted, due to binary searching in g_part_alias_name(). It turned out that > g_part_alias_name() did a linear search, so the list didn't strictly need > to be sorted. But, there was talk of potentially switching to a binary > search later, so Allan went with the sorted version. > > ae@ and kib@ voiced some concerns: > > From: on behalf of "Andrey V. Elsukov" > > Date: 2015-12-28, Monday at 00:32 > To: Allan Jude , , < > svn-src-all@freebsd.org>, > Subject: Re: svn commit: r292788 - in head/sys: geom/part sys > > > > This enum could be used by third-party kernel module and in general it > > is not good to change the order of elements here. This can break `gpart > > show` output for such modules. Just for the future. :) > > > From: on behalf of Konstantin Belousov > > Date: 2015-12-28, Monday at 02:49 > To: "Andrey V. Elsukov" > Cc: Allan Jude , , < > svn-src-all@freebsd.org>, > Subject: Re: svn commit: r292788 - in head/sys: geom/part sys > > > > If the enum values are considered part of KBI, then explicit assignment > > of the enum values is much preferred. > > > As best as I can tell, nothing in base/head or ports/head looks at the GPT > UUIDs or aliases (outside of GEOM_PART itself, of course), so ae@ and kib@'s > concerns are not an issue at this time. Therefore, my plan is to insert the > new alias and UUID entries into the various enums and lists in-order, > rather than just appending. Any objections? > > Thanks, > > Ravi (rpokala@) > > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)