From owner-freebsd-net@FreeBSD.ORG Tue Feb 3 10:33:37 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B246F16A4CE for ; Tue, 3 Feb 2004 10:33:37 -0800 (PST) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 097E543D54 for ; Tue, 3 Feb 2004 10:33:35 -0800 (PST) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.10/8.12.3) with ESMTP id i13IXW2h010085 for ; Tue, 3 Feb 2004 10:33:32 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.10/8.12.3/Submit) id i13IXWNG010084 for net@freebsd.org; Tue, 3 Feb 2004 10:33:32 -0800 Date: Tue, 3 Feb 2004 10:33:32 -0800 From: Brooks Davis To: net@freebsd.org Message-ID: <20040203183332.GD27244@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zbGR4y+acU1DwHSi" Content-Disposition: inline User-Agent: Mutt/1.5.4i X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Subject: removing if_withname() X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 18:33:37 -0000 --zbGR4y+acU1DwHSi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Bruce pointed out that if_withname is inconsistent about IFNAMSIZ. I was looking at it and cleaned it up, but then I realized that it is a really inefficient implementation of ifnet_byindex(sdl->sdl_index). It turns out that it's also completely unused so I'd like to remove it entirely rather then fixing it since it's both broken and pointless. Is there any reason not to do so? I used glimpse and rwatson's fxr to verify that it's unused: http://fxr.watson.org/fxr/ident?i=3Dif_withname -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --zbGR4y+acU1DwHSi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFAH+l6XY6L6fI4GtQRAikHAJ9oVkHUOj3lt0qJcYq1Tgk9AI/5AwCgl8LM qFHT1uRR/GkDCX3TJMLrjfA= =yEAV -----END PGP SIGNATURE----- --zbGR4y+acU1DwHSi--