From owner-svn-ports-all@freebsd.org Fri Sep 18 19:48:09 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BFB99CEA50 for ; Fri, 18 Sep 2015 19:48:09 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D20F915AF for ; Fri, 18 Sep 2015 19:48:08 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: (qmail 86317 invoked by uid 89); 18 Sep 2015 19:48:00 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 18 Sep 2015 19:48:00 -0000 Received: (qmail 44319 invoked by uid 89); 18 Sep 2015 17:59:17 -0000 Received: by simscan 1.3.1 ppid: 44310, pid: 44314, t: 0.0038s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 18 Sep 2015 17:59:17 -0000 Received: (qmail 31461 invoked by uid 89); 18 Sep 2015 17:59:17 -0000 Received: by simscan 1.4.0 ppid: 31453, pid: 31457, t: 0.9550s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 18 Sep 2015 17:59:16 -0000 From: Jan Beich To: Sunpoet Po-Chuan Hsieh Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r397252 - in head/devel: android-tools-adb android-tools-adb-devel android-tools-adb-devel/files References: <201509181542.t8IFgncC023933@repo.freebsd.org> Date: Fri, 18 Sep 2015 19:59:04 +0200 In-Reply-To: (Sunpoet Po-Chuan Hsieh's message of "Sat, 19 Sep 2015 00:09:30 +0800") Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2015 19:48:09 -0000 --=-=-= Content-Type: text/plain Sunpoet Po-Chuan Hsieh writes: > On Fri, Sep 18, 2015 at 11:42 PM, Jan Beich wrote: > >> Author: jbeich >> Date: Fri Sep 18 15:42:48 2015 >> New Revision: 397252 >> URL: https://svnweb.freebsd.org/changeset/ports/397252 >> >> Log: >> devel/android-tools-adb-devel: add unit tests like simpleperf [...] >> Modified: head/devel/android-tools-adb-devel/Makefile [...] >> +OPTIONS_DEFINE= TEST [...] >> Modified: head/devel/android-tools-adb/Makefile [...] >> -OPTIONS_DEFINE= BASH DOCS >> +OPTIONS_DEFINE+=BASH DOCS > > Hello, > > According to commit log, it seems this is an unintentional change. > And "=" is enough here. -devel is a slave port and needs to add TEST option in *addition* to those defined in master. Tests based on gtest were added upstream only recently thus not available in adb-5.1.1. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJV/FDoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bELUH/jmttycIZ6sQI7gS2HiDmNmD 10anfZdPfm2KfhtldCmaR7GZBOE3nsuvH9UsuG1gwRoteBHJ0EbhLq4lLtoP7scY 4ga321VlIuWFUWC+fkXJJrewg5ooQH7AhPjA4rD8anB5zFmXJ/EQOkE5pUZunBic j9Pws/u32VCqgou5o1rDOlYdLaIzyfgbNgBfuspCJYs2dMKnjPAF7W9GE1vemPvd IV5HTew7oYMkZesljQjrXjJY7mibgL7rOV4RLqtw4hBlOuo34XB1I7z4IIqRbdc1 MxOs3ajfIs2t9o6d/5RdWdFQ6Syt1WAnxugrUFoNAaV1PKfeyadgdga5SNVjsM8= =jVzX -----END PGP SIGNATURE----- --=-=-=--