From owner-freebsd-current@freebsd.org  Sat Nov 23 13:41:33 2019
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9054A1B60AD
 for <freebsd-current@mailman.nyi.freebsd.org>;
 Sat, 23 Nov 2019 13:41:33 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47KvbK2cbnz44Wx
 for <freebsd-current@freebsd.org>; Sat, 23 Nov 2019 13:41:33 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com
 [209.85.222.181])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 349421CC00
 for <freebsd-current@freebsd.org>; Sat, 23 Nov 2019 13:41:33 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qk1-f181.google.com with SMTP id q70so8782386qke.12
 for <freebsd-current@freebsd.org>; Sat, 23 Nov 2019 05:41:33 -0800 (PST)
X-Gm-Message-State: APjAAAXqkv/gjHl04eXy4j97POtaNuvRSmdR7gkmk+ul46OF6PkyCAs4
 M4nMkECv80xsWGXzU45IdrERuZPrcS3ZMQ5IALk=
X-Google-Smtp-Source: APXvYqyt9DGFDlOolLkIze0ABLMQYQsbRytOalTHe+nw5BLocaS17RF1EB3pLlDw2btJ3sq3hw+Zf9zei1RGPbd8rHw=
X-Received: by 2002:a37:a00f:: with SMTP id j15mr18432187qke.103.1574516492558; 
 Sat, 23 Nov 2019 05:41:32 -0800 (PST)
MIME-Version: 1.0
References: <CB176B47-1E47-439E-9B4A-8F36A7C2DDD3.ref@yahoo.com>
 <CB176B47-1E47-439E-9B4A-8F36A7C2DDD3@yahoo.com>
In-Reply-To: <CB176B47-1E47-439E-9B4A-8F36A7C2DDD3@yahoo.com>
From: Kyle Evans <kevans@freebsd.org>
Date: Sat, 23 Nov 2019 07:41:21 -0600
X-Gmail-Original-Message-ID: <CACNAnaGHOoTtqbOOZ9oRcCLcSH_NE=L6fXBA2PtSGh1T19mXDA@mail.gmail.com>
Message-ID: <CACNAnaGHOoTtqbOOZ9oRcCLcSH_NE=L6fXBA2PtSGh1T19mXDA@mail.gmail.com>
Subject: Re: head r355027 fails to (non-debug) build for:
 sys/arm/broadcom/bcm2835/bcm2835_sdhci.c:721:26:
 error: unused variable 'sc
To: Mark Millard <marklmi@yahoo.com>
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Nov 2019 13:41:33 -0000

On Sat, Nov 23, 2019 at 2:42 AM Mark Millard <marklmi@yahoo.com> wrote:
>
> --- bcm2835_sdhci.o ---
> /usr/src/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c:721:26: error: unused variable 'sc' [-Werror,-Wunused-variable]
>         struct bcm_sdhci_softc *sc = device_get_softc(slot->bus);
>                                 ^
> 1 error generated.
>
> This is because the sc is only used in:
>
>         KASSERT(sc->dmamap_seg_count == 0,
>             ("data pending interrupt pushed through SDHCI framework"));
>
> and this was a non-debug build: so the KASSERT did not use sc either.
>
>

Whoops, sorry about that! Fixed in r355031.

Thanks,

Kyle Evans