From owner-freebsd-current@FreeBSD.ORG Tue Aug 26 19:45:14 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8656528F; Tue, 26 Aug 2014 19:45:14 +0000 (UTC) Received: from mail-we0-x229.google.com (mail-we0-x229.google.com [IPv6:2a00:1450:400c:c03::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C1757329B; Tue, 26 Aug 2014 19:45:13 +0000 (UTC) Received: by mail-we0-f169.google.com with SMTP id u56so15162118wes.28 for ; Tue, 26 Aug 2014 12:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=JxCPFPdqaeTa/QlFfQjxH0ghjyEI72IIxXRoWWQtOSI=; b=I5r6sZnhNDwmfGvZciUgZYyYBY00Ukf+3MrUu+tW8tsPjcCLVdB9zrVOuM3f+Xc1Dv sEYwjFxS8+kHLnTyTGf8RWK5V/GgXBZMmPp8lTp1KPFmHuBMPJkTgH2UX1LpunXPgwWs /UJRbNjty60FQBA1bVEREQFA4yDlEA/+kLYFjW8pg1nf6rOpbbqsruK6A5HXQ/7n9S8j ShHxPIe9gAHQnY4Tj2zAGkWAGLXXG5H2iCZnzeEuuDMhpphI5VLNhkfGYHqAx5eiRTrX HmReCgnfDwBb03lB+Aoz3w6cL2uiuJbK9mnNPAjWQ4MI57SedAzRcScMe6nY7okvAKcH vZHA== MIME-Version: 1.0 X-Received: by 10.194.81.230 with SMTP id d6mr24272757wjy.49.1409082312002; Tue, 26 Aug 2014 12:45:12 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.194.126.1 with HTTP; Tue, 26 Aug 2014 12:45:11 -0700 (PDT) In-Reply-To: <8e598a07cf5bc8690749120295936c40@mail.feld.me> References: <5256B761.4050301@gmail.com> <1381421583.19140.32451849.084D8E32@webmail.messagingengine.com> <5256E2D5.4060101@allanjude.com> <1387388390.28188.61199633.413D38F8@webmail.messagingengine.com> <53A7CE1B.7090400@gmail.com> <8e598a07cf5bc8690749120295936c40@mail.feld.me> Date: Tue, 26 Aug 2014 13:45:11 -0600 X-Google-Sender-Auth: xKuwF7iELCc3-1PUIeutgnLlR7E Message-ID: Subject: Re: FreeBSD 10 and zfsd From: Alan Somers To: Mark Felder Content-Type: text/plain; charset=UTF-8 Cc: Johan Hendriks , FreeBSD CURRENT , Alan Somers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2014 19:45:14 -0000 On Tue, Aug 26, 2014 at 1:39 PM, Mark Felder wrote: > August 26 2014 10:21 AM, "Alan Somers" wrote: >> >> Merged into the projects/zfsd/head branch by change 270604. Merging >> to head is blocked by three issues: >> a) The atf-ksh93 hack. The correct solution is to modify all the test >> programs (not the test cases) so they can run under /bin/sh. That >> will take some effort. > > Can you provide a link to the atf-ksh93 code? There's not much to it. It simply sets an environment variable and calls atf-sh. What's more interesting is libtest.kshlib. In order to eliminate atf-ksh93, we would need to modify libtest.kshlib to run under /bin/sh. Alternatively, it may be easier to split libtest.kshlib into two files: a small /bin/sh-compatible that can be sourced by the ATF test programs, and a ksh93 script that only needs to be sourced by the ATF test cases. https://svnweb.freebsd.org/base/projects/zfsd/head/libexec/atf/atf-ksh93/ https://svnweb.freebsd.org/base/projects/zfsd/head/tests/sys/cddl/zfs/include/libtest.kshlib