From owner-svn-ports-head@freebsd.org Wed Nov 7 12:12:20 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E181F112544E; Wed, 7 Nov 2018 12:12:19 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6D0F68EA0C; Wed, 7 Nov 2018 12:12:19 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 38679ABB0; Wed, 7 Nov 2018 12:12:19 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id E7D8898EE3; Wed, 7 Nov 2018 13:12:17 +0100 (CET) Date: Wed, 7 Nov 2018 13:12:17 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Cc: Koichiro Iwao , Niclas Zeising , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r484357 - head/mail/spamassassin Message-ID: <20181107121217.p5ira4vn556t4t2z@ivaldir.net> References: <201811062146.wA6LknN3005274@repo.freebsd.org> <20181107083105.55o52urafcgdthec@ivaldir.net> <20181107091004.xbvzfyviyrkcbi2m@icepick.vmeta.jp> <20181107092211.dgcvichyunbss35x@ivaldir.net> <2b3670de-7625-d458-7c93-5ea0a7ae2af1@freebsd.org> <20181107095528.szgl6dytu7zuos5r@icepick.vmeta.jp> <20181107101513.GA81078@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aaqltdrvglpqvyyj" Content-Disposition: inline In-Reply-To: <20181107101513.GA81078@FreeBSD.org> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 6D0F68EA0C X-Spamd-Result: default: False [-108.62 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-1.00)[-1.000,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; IP_SCORE(-3.41)[ip: (-8.57), ipnet: 96.47.64.0/20(-4.67), asn: 11403(-3.74), country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 12:12:20 -0000 --aaqltdrvglpqvyyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 07, 2018 at 10:15:13AM +0000, Alexey Dokuchaev wrote: > On Wed, Nov 07, 2018 at 06:55:28PM +0900, Koichiro Iwao wrote: > > ... > > +1 to single port. I concern about not all people need that patch. Can > > FLAVORS be used to create packages with/without Japanese patches? > > I know it can be used to handle multiple versions of PHP, Python, etc. >=20 > There's nothing wrong with a patch not being *useful* to all people, > the question is would it break anything for anyone. If there are no > undesired side effects just commit it without hiding it behind options > or flavors. >=20 > ./danfe I agree with danfe here! if needed we can in the end play with flavors yes, but if the patch does not break things to anyone and brings good for japane= se people let's just have the patch in and no options/flavors :) Best regards, Bapt --aaqltdrvglpqvyyj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlvi1p0ACgkQY4mL3PG3 PloY/xAApbGylez7yAb1b7FxnBumqkPG6fcnKVKIeUgHJ93GZzxlTafwHtqIIvaG scpn3A9IJV2Ilwf8wwQXyK++6tQSEwD32ywveZ0pGy4dSmmkmSEDJKE8KljbB4Tr MuMIWPLb2K4zTLvXFbL1S8Me7LJYCwzRu1+h7lURfUyVHA6YWhSodhgSZbv1Mw9C VT4kQC8Y9yi7xi6YrKGt1tpM9OqJ9zX4V/YA6fPwyk0KyCYFAqMH59d4pSF+AMET uQcofL3stzAbRegnonVxm5SCJ3EPkcH8ru1wSYSle4NusVcQ3fML/Q0pClKUNuL2 G/FWJrof8lTD7xfFTwECUQhdz1Lh9ZbYCbxXmRlQcZ55UvX8W2VZh/ic7Saoa53Z NIyolWYR/zPVWU9MwhQlwLJOYcPw5p2WQHiNxa8RQBnwi6q7ao75dsx3m2RqPB0S OU86XATtizP6Nbf2OxjWEhOH4l84fzeew/hkrJN9G+8TjQHTnGwHQLPl/tFpYXY1 QuI9fQdclL8X7ZS7vasN33phjbflrAgHoO6MR4ECAZETvIhjKbd06GMcedqlI/HZ vc99UQ2jjH+z1IvEVz1wO6WiJfYe1fDf5+nh42GhpUmtubXrsF2ZTUeOot+Sxpun oAcvSek4Dvzw6dMfpIfdcfOM5MVeQsDEO4CNJTLez6RypNVoUMo= =HTb/ -----END PGP SIGNATURE----- --aaqltdrvglpqvyyj--