From nobody Wed Apr 5 07:58:12 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Prxnx2hNBz4432m; Wed, 5 Apr 2023 07:58:13 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Prxnx0BcWz4BNT; Wed, 5 Apr 2023 07:58:13 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680681493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nBz0qpLwvIaNkpB4LRUuU09zqkqmaf6xoMUkXxkI+j4=; b=IWvEtbCUiGlTt9ftNCdGoVKAcNMrxBcqNVUeEapDXCGaXpYJJRt+qo5GnFiaoGiX5iR1vh bgDebNoTeyf+K798r9alH6usgxrBlmtnw/xi7FrkLn06PuYVkQT7HNYLgWdjOpr2SBZDac PgdC8TczgbGIfIko4yG9JAf+rkfyBVACuEKcjP6K8xLi/WV+bhOf5qipgUOoQ6XHVfUd8F LvEqdUzzs3rNtndxFIRJMpLImTOYaNADWNLApW014b07uJLlRJm000RKTooedo+i55u5zD TtS62msJOTpbsbgnmC4XSY/yEumhhTnxMjwJB9xYfbMSdXhQ2H5XT3gfZupy/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680681493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nBz0qpLwvIaNkpB4LRUuU09zqkqmaf6xoMUkXxkI+j4=; b=BwQlOz21lKH6aX4FFTCwZl8pi7y2v0fvSV3hEGCj4GKqzQIIk1bJpUJKS+LeHoY19U6qOq lH6Sp0snl+ob5mRnYMy9jBEg6avUAF/NGLyPeM7quPsYIoeQvGZZcU92tuBwmW+C9wp+MM glu0lPmEMgujYdQSgH1td0I7d9QEw4lIVgyX4/XL4I4c+AfnOlTHVyv/9j0tsx430/qpsl BCBYooCpgZ3la+V63XqOkNdZN6dMUpr64GU4kD4UGB/9/TE2xCESzODKu/67ZnxsM+pSqW yBivwHkOWGT5pv4O15PCjcmaMers6I5w9CQ0lznxR3OY+T4sWvlT5eDaSgQ8rQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680681493; a=rsa-sha256; cv=none; b=sEdcpV7ggClaQ7pPfzZ8VYpxTo9EXMc8aYX+5glqmx5OkKnyB+fWC3AkEwrCPiOcpcGhUA dRtGa46S1E5ey/OY2dV2n6ocJi4PyhtFvjgpVFLv0y8L3gsf1CCfa+kaR/+14J0Hy3gTAo rvTXrMjkOA0NaI6c2gCMpgsom05otArAUip5zyOfatbb/oUl5Yrmu/35WdXG8y/ejomNTA wsMCuBzBBUDMAe86xTnvw0naCSjMXQb6Tx9VU/B69b5/hfhgxQjcAigfirhrx0mnbqHvTP 1H0PHr7oLe67kPxInejB11zPq/VWQr08YPO6/U0XxaZSHvQWuwEWT9yTWaDwQA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id E753A1952E; Wed, 5 Apr 2023 07:58:12 +0000 (UTC) Date: Wed, 5 Apr 2023 07:58:12 +0000 From: Alexey Dokuchaev To: Fernando Apestegu??a Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e933541b2131 - main - devel/samurai: Fix if LOCALBASE is not /usr/local Message-ID: References: <202304050543.3355hcZX012345@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202304050543.3355hcZX012345@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 05, 2023 at 05:43:38AM +0000, Fernando Apestegu??a wrote: > commit e933541b2131d644ce243630544bcf210fb4be84 > > devel/samurai: Fix if LOCALBASE is not /usr/local > > PR: 270590 > Reported by: eric@camachat.org > ... > PORTNAME= samurai > DISTVERSION= 1.2-16 > +PORTREVISION= 1 Needless bump for build-time change? > -@@ -3,7 +3,7 @@ > - PREFIX=/usr/local > +@@ -1,10 +1,10 @@ > + .POSIX: > + .PHONY: all install clean > + > +-PREFIX=/usr/local > ++PREFIX=${LOCALBASE} This doesn't look right, PREFIX is semantically different from LOCALBASE even though they typically point to the same path (PREFIX is where your generated stuff goes, LOCALBASE is where you get precursors). If this program abuses the PREFIX variable and it is actually meant to be LOCALBASE, it's better to fix the Makefile or at least accompany such change with due comment. ./danfe