From owner-freebsd-net@FreeBSD.ORG  Wed Sep 21 17:33:14 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4676916A41F
	for <freebsd-net@freebsd.org>; Wed, 21 Sep 2005 17:33:14 +0000 (GMT)
	(envelope-from freebsd-net@m.gmane.org)
Received: from ciao.gmane.org (main.gmane.org [80.91.229.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A5D9C43D46
	for <freebsd-net@freebsd.org>; Wed, 21 Sep 2005 17:33:13 +0000 (GMT)
	(envelope-from freebsd-net@m.gmane.org)
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1EI8Oo-0001hk-J6
	for freebsd-net@freebsd.org; Wed, 21 Sep 2005 19:28:50 +0200
Received: from mulder.f5.com ([205.229.151.150])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <freebsd-net@freebsd.org>; Wed, 21 Sep 2005 19:28:50 +0200
Received: from atkin901 by mulder.f5.com with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <freebsd-net@freebsd.org>; Wed, 21 Sep 2005 19:28:50 +0200
X-Injected-Via-Gmane: http://gmane.org/
To: freebsd-net@freebsd.org
From: othermark <atkin901@yahoo.com>
Date: Wed, 21 Sep 2005 10:26:11 -0700
Lines: 22
Message-ID: <dgs53j$348$1@sea.gmane.org>
References: <dgp7lk$sov$1@sea.gmane.org>
	<20050921.012626.74752754.Noritoshi@Demizu.ORG>
	<20050921.161113.59648691.Noritoshi@Demizu.ORG>
	<20050921.184114.115904070.Noritoshi@Demizu.ORG>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7Bit
X-Complaints-To: usenet@sea.gmane.org
X-Gmane-NNTP-Posting-Host: mulder.f5.com
User-Agent: KNode/0.9.2
Sender: news <news@sea.gmane.org>
Subject: Re: rfc2385 (tcp md5 checksums) in -current broken?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Sep 2005 17:33:14 -0000

Noritoshi Demizu wrote:
 
> --- print-tcp.c-ORG   Thu Apr 21 15:36:05 2005
> +++ print-tcp.c       Wed Sep 21 18:43:51 2005
> @@ -799,7 +799,7 @@
>  MD5_Update(&ctx, tcpmd5secret, strlen(tcpmd5secret));
>  MD5_Final(sig, &ctx);
>  
> -     if (memcmp(rcvsig, sig, 16))
> +     if (memcmp(rcvsig, sig, TCP_SIGLEN) == 0)
>  return (SIGNATURE_VALID);
>  else
>  return (SIGNATURE_INVALID);

The original code there certainly looks wrong!  After patching, FreeBSD's
checksum returns valid.  I'll have to see what's up with the originating
checksum.  Many Thanks!

-- 
othermark
atkin901 at nospam dot yahoo dot com
(!wired)?(coffee++):(wired);