From nobody Wed Sep 28 14:20:06 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MczCq1FrHz4YFTb; Wed, 28 Sep 2022 14:20:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MczCq0c37z3dNP; Wed, 28 Sep 2022 14:20:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664374807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w1SnQ464iIPZOYdCMp+d9tFuNvmbHUbHqIJxAKBOXQA=; b=Ie5ZlMLVAPyw6KWz3Q8NxLzyo8aE/JgRxwW8WeNMT6jySf0ur7J5YQgQWxz3UtIYwcBBaQ +7hFrvayuNxucmcOu7MM0E608NDeYCFrJcL1rmgWM2JvKZpFcbqA65vq4q52B5SetxRnXq 9+ybQK48qqms1KrBu9/EorymsyhF2GX9sk08vUw9jbPDCcuQho8cwUf9x4+BMN3y8ia3S8 EKcv/PErgC3cK86fBswZx+MxKPioqcvdk0q+tkkuSaf6ASH/wYOrYyEI4ugIv2AXY3BS+9 WH7vYz0wp/5tRtXBb5o+KytPRVIqZAtdUeh5vdFFIMagMuv4IulWs/8EZpV28Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MczCp6gK5zVh4; Wed, 28 Sep 2022 14:20:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28SEK6dw031003; Wed, 28 Sep 2022 14:20:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28SEK6ND031000; Wed, 28 Sep 2022 14:20:06 GMT (envelope-from git) Date: Wed, 28 Sep 2022 14:20:06 GMT Message-Id: <202209281420.28SEK6ND031000@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Mathieu Arnold Subject: git: 36ab384abd04 - main - dns/bind9*: fix some race condition in rc script List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mat X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 36ab384abd0413b0e3b9ef0c8e7f994eb03d456c Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664374807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w1SnQ464iIPZOYdCMp+d9tFuNvmbHUbHqIJxAKBOXQA=; b=jeIhuDIR/o/h8RvPRQQOIvKk18QDj8waG4QpagA2VCRQKU8UE7NF+CQN6gkzZc0BXbNtsn 4U/pWSFbA8P5R+008T+3/Pgsy/M9UrbQI1OSekHIGN3bqDagrrTz73aR1woQUEsL8yC3ik TIkJ9PZLE2GNiPUZkLcgr0PM0UPZ65zD85KFPIB0ia2Y+Rw0mkeJsmn92jcIL+3MWwVa1z y8wgM9SYt1jKrEp+4H7td/twrSTSTo0YHuAT4qnAjfrT9Ozc1wcV2l3e3QUT//H4oAo3z/ 8KEi5GqgZ/KzXd7tzWp6F2pvAUFLhOmEQZB620bANmXknWLX/aDJE6fBaRhQ2A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664374807; a=rsa-sha256; cv=none; b=Y8yjNKw2ae44u/a8vkU3uUbUMz3FN4AvTdL0u5fWhO4/gpdZtrA5k2tVRQ5sfne5j0kNLm nWdZiO3cHOg3ufxbxDtKQ2PIjr9OFWBm59FcpqqQrc1OQPBEmZaGdyhwmLrD5jhLOSBt9Y 6yhVHlUjM54cUtMFa9CBQPHgtYL1spcGQ5YBpnqzKRnwTpWAQvq0e4QTt2LSt7T7fkO09e uj0x6wsoEDGjauqNwCPPJyevZwMMmvDfxR9A5VRkXKSbjbb0jwVaeq+Q8qEKrKFGxElrj8 SpMkMsfHX/ej+ADOjmzekEMlhinZzeQ4mIeeYOfVZnX8cE8cVTNyTL570yltWA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mat: URL: https://cgit.FreeBSD.org/ports/commit/?id=36ab384abd0413b0e3b9ef0c8e7f994eb03d456c commit 36ab384abd0413b0e3b9ef0c8e7f994eb03d456c Author: Michael Sinatra AuthorDate: 2022-09-28 14:17:27 +0000 Commit: Mathieu Arnold CommitDate: 2022-09-28 14:19:36 +0000 dns/bind9*: fix some race condition in rc script PR: 265994 MFH: yes --- dns/bind9-devel/Makefile | 2 +- dns/bind9-devel/files/named.in | 36 ++++++++++++++++++------------------ dns/bind916/Makefile | 2 +- dns/bind916/files/named.in | 36 ++++++++++++++++++------------------ dns/bind918/Makefile | 2 +- dns/bind918/files/named.in | 36 ++++++++++++++++++------------------ 6 files changed, 57 insertions(+), 57 deletions(-) diff --git a/dns/bind9-devel/Makefile b/dns/bind9-devel/Makefile index a30713ccc3fa..ee6d9e53b2c6 100644 --- a/dns/bind9-devel/Makefile +++ b/dns/bind9-devel/Makefile @@ -8,7 +8,7 @@ PORTREVISION= 0 .else # XXX: correct version # dns/bind9xx here -PORTREVISION= 0 +PORTREVISION= 1 .endif CATEGORIES= dns net # XXX: put the ISC master_site diff --git a/dns/bind9-devel/files/named.in b/dns/bind9-devel/files/named.in index 0d19435000cc..ee2fbcb821a7 100644 --- a/dns/bind9-devel/files/named.in +++ b/dns/bind9-devel/files/named.in @@ -309,6 +309,24 @@ rndc() named_prestart() { + # Is the user using a sandbox? + # + if [ -n "${named_chrootdir}" ]; then + rc_flags="${rc_flags} -t ${named_chrootdir}" + checkyesno named_chroot_autoupdate && chroot_autoupdate + + case "${altlog_proglist}" in + *named*) + ;; + *) + warn 'Using chroot without setting altlog_proglist, logging may not' + warn 'work correctly. Run sysrc altlog_proglist+=named' + ;; + esac + else + named_symlink_enable=NO + fi + find_pidfile find_sessionkeyfile @@ -334,24 +352,6 @@ named_prestart() local line nsip firstns - # Is the user using a sandbox? - # - if [ -n "${named_chrootdir}" ]; then - rc_flags="${rc_flags} -t ${named_chrootdir}" - checkyesno named_chroot_autoupdate && chroot_autoupdate - - case "${altlog_proglist}" in - *named*) - ;; - *) - warn 'Using chroot without setting altlog_proglist, logging may not' - warn 'work correctly. Run sysrc altlog_proglist+=named' - ;; - esac - else - named_symlink_enable=NO - fi - # Create an rndc.key file for the user if none exists # confgen_command="${_named_program_root}/sbin/rndc-confgen -a -b256 -u ${named_uid} \ diff --git a/dns/bind916/Makefile b/dns/bind916/Makefile index d7ece0342c51..ffae4aad8fe7 100644 --- a/dns/bind916/Makefile +++ b/dns/bind916/Makefile @@ -2,7 +2,7 @@ PORTNAME= bind PORTVERSION= ${ISCVERSION:S/-P/P/:S/b/.b/:S/a/.a/:S/rc/.rc/} -PORTREVISION= 0 +PORTREVISION= 1 CATEGORIES= dns net MASTER_SITES= ISC/bind9/${ISCVERSION} PKGNAMESUFFIX= 916 diff --git a/dns/bind916/files/named.in b/dns/bind916/files/named.in index 48681ca12f3b..6e225efe0733 100644 --- a/dns/bind916/files/named.in +++ b/dns/bind916/files/named.in @@ -311,6 +311,24 @@ rndc() named_prestart() { + # Is the user using a sandbox? + # + if [ -n "${named_chrootdir}" ]; then + rc_flags="${rc_flags} -t ${named_chrootdir}" + checkyesno named_chroot_autoupdate && chroot_autoupdate + + case "${altlog_proglist}" in + *named*) + ;; + *) + warn 'Using chroot without setting altlog_proglist, logging may not' + warn 'work correctly. Run sysrc altlog_proglist+=named' + ;; + esac + else + named_symlink_enable=NO + fi + find_pidfile find_sessionkeyfile @@ -346,24 +364,6 @@ named_prestart() local line nsip firstns - # Is the user using a sandbox? - # - if [ -n "${named_chrootdir}" ]; then - rc_flags="${rc_flags} -t ${named_chrootdir}" - checkyesno named_chroot_autoupdate && chroot_autoupdate - - case "${altlog_proglist}" in - *named*) - ;; - *) - warn 'Using chroot without setting altlog_proglist, logging may not' - warn 'work correctly. Run sysrc altlog_proglist+=named' - ;; - esac - else - named_symlink_enable=NO - fi - # Create an rndc.key file for the user if none exists # confgen_command="${_named_program_root}/sbin/rndc-confgen -a -b256 -u ${named_uid} \ diff --git a/dns/bind918/Makefile b/dns/bind918/Makefile index 7e8706f62ca2..1e9a31a9ab57 100644 --- a/dns/bind918/Makefile +++ b/dns/bind918/Makefile @@ -7,7 +7,7 @@ PORTVERSION= ${ISCVERSION:S/-P/P/:S/b/.b/:S/a/.a/:S/rc/.rc/} PORTREVISION= 0 .else # dns/bind918 here -PORTREVISION= 0 +PORTREVISION= 1 .endif CATEGORIES= dns net MASTER_SITES= ISC/bind9/${ISCVERSION} diff --git a/dns/bind918/files/named.in b/dns/bind918/files/named.in index 8a614f6256a5..fb2a9453ad42 100644 --- a/dns/bind918/files/named.in +++ b/dns/bind918/files/named.in @@ -309,6 +309,24 @@ rndc() named_prestart() { + # Is the user using a sandbox? + # + if [ -n "${named_chrootdir}" ]; then + rc_flags="${rc_flags} -t ${named_chrootdir}" + checkyesno named_chroot_autoupdate && chroot_autoupdate + + case "${altlog_proglist}" in + *named*) + ;; + *) + warn 'Using chroot without setting altlog_proglist, logging may not' + warn 'work correctly. Run sysrc altlog_proglist+=named' + ;; + esac + else + named_symlink_enable=NO + fi + find_pidfile find_sessionkeyfile @@ -334,24 +352,6 @@ named_prestart() local line nsip firstns - # Is the user using a sandbox? - # - if [ -n "${named_chrootdir}" ]; then - rc_flags="${rc_flags} -t ${named_chrootdir}" - checkyesno named_chroot_autoupdate && chroot_autoupdate - - case "${altlog_proglist}" in - *named*) - ;; - *) - warn 'Using chroot without setting altlog_proglist, logging may not' - warn 'work correctly. Run sysrc altlog_proglist+=named' - ;; - esac - else - named_symlink_enable=NO - fi - # Create an rndc.key file for the user if none exists # confgen_command="${_named_program_root}/sbin/rndc-confgen -a -b256 -u ${named_uid} \