From owner-cvs-all@FreeBSD.ORG  Thu Mar 18 17:13:44 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9B24C16A4CE; Thu, 18 Mar 2004 17:13:44 -0800 (PST)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4E3D543D1F; Thu, 18 Mar 2004 17:13:44 -0800 (PST)
	(envelope-from gerald@pfeifer.com)
Received: from [128.131.111.60] (acrux [128.131.111.60])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP
	id 182891379C; Fri, 19 Mar 2004 02:13:43 +0100 (CET)
Date: Fri, 19 Mar 2004 02:13:50 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: David O'Brien <obrien@FreeBSD.org>
In-Reply-To: <20040317182432.GA96023@dragon.nuxi.com>
Message-ID: <Pine.BSF.4.58.0403190206360.94079@acrux.dbai.tuwien.ac.at>
References: <200403170818.i2H8IFYU008824@repoman.freebsd.org>
	<Pine.BSF.4.58.0403171036060.94079@acrux.dbai.tuwien.ac.at>
	<Pine.BSF.4.58.0403171135480.94079@acrux.dbai.tuwien.ac.at>
	<20040317182432.GA96023@dragon.nuxi.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/lang/gcc34 Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Mar 2004 01:13:44 -0000

On Wed, 17 Mar 2004, David O'Brien wrote:
>>> Have you tested this following the instructions at
>>>  http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-testing.html
>> I *DID* test on i386 (5.2-CURRENT, full 'make world' just before testing
>> the port).
> I just re-tested on FreeBSD/i386:
>
>     kieu(r):/usr/ports/lang/gcc34> /usr/bin/time -h make package
>     ...
>     Creating bzip'd tar ball in '/usr/ports/lang/gcc34/gcc-3.4.0_20040310.tbz'
>             49m57.11s real          16m21.78s user          7m13.72s sys
>     kieu(r):/usr/ports/lang/gcc34> ll gcc-3.4.0_20040310.tbz
>     -rw-r--r--  1 root  ncvs  13.0M Mar 17 09:48 gcc-3.4.0_20040310.tbz

Well, this is just one part of the testing required for port updates.

If you follow the instructions in the Porters' Handbook, you'll note
that `make deinstall` got broken, as I just verified on beast

  rmdir: /j/gerald/lib/gcc/alpha-portbld-freebsd5.2: Directory not empty
  rmdir: /j/gerald/lib/gcc: Directory not empty

with the patch below.

Gerald

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/lang/gcc34/Makefile,v
retrieving revision 1.166
diff -3 -u -p -r1.166 Makefile
--- Makefile	17 Mar 2004 14:21:58 -0000	1.166
+++ Makefile	19 Mar 2004 01:11:38 -0000
@@ -43,7 +43,7 @@ NOMANCOMPRESS=	yes	# too hard to deal wi
 .if ${ARCH} == "amd64"
 CONFIGURE_TARGET=	x86_64-portbld-freebsd${OSREL}
 .else
-CONFIGURE_TARGET=	${ARCH}-portbld-freebsd${OSREL}
+#CONFIGURE_TARGET=	${ARCH}-portbld-freebsd${OSREL}
 .endif

 .if ${ARCH} == ia64  ||  ${ARCH} == sparc64