From owner-freebsd-hackers Fri Oct 18 23:13:41 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA18537B401; Fri, 18 Oct 2002 23:13:40 -0700 (PDT) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54E8243E97; Fri, 18 Oct 2002 23:13:40 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.5/8.12.4) with ESMTP id g9J6DePQ023135; Fri, 18 Oct 2002 23:13:40 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.5/8.12.4/Submit) id g9J6Debh023134; Fri, 18 Oct 2002 23:13:40 -0700 (PDT) (envelope-from dillon) Date: Fri, 18 Oct 2002 23:13:40 -0700 (PDT) From: Matthew Dillon Message-Id: <200210190613.g9J6Debh023134@apollo.backplane.com> To: Maxim Sobolev Cc: hackers@FreeBSD.ORG Subject: Re: Patch to allow a driver to report unrecoverable write errors to the buf layer References: <3DB048B5.21097613@FreeBSD.org> <200210181807.g9II7cBY024485@apollo.backplane.com> <3DB0516F.9BE00F57@FreeBSD.org> <200210181835.g9IIZsBX061970@apollo.backplane.com> <20021019051202.GB14922@vega.vega.com> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG : :Hmm, the current approach doesn't look all that "right" to me, because we are :retrying operation even though the upper-layer code that initiated it was :already notified about the failure (e.g. received EIO), so that it should not :assume that the data was actually written successfully. Or I am missing :something? : :-Maxim Yah, most writes issued through the buffer cache are asynchronous or delayed. So the VFS layer that initiated the write is not necessarily going to be notified of a failure. Thus the failure notification does not help us here. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message