From owner-freebsd-commit  Fri May 19 09:03:22 1995
Return-Path: commit-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id JAA25464
          for commit-outgoing; Fri, 19 May 1995 09:03:22 -0700
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id JAA25425
          for cvs-sys-outgoing; Fri, 19 May 1995 09:03:08 -0700
Received: from ref.tfs.com (ref.tfs.com [140.145.254.251])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id JAA25419
          ; Fri, 19 May 1995 09:03:07 -0700
Received: (from phk@localhost) by ref.tfs.com (8.6.8/8.6.6) id JAA04882; Fri, 19 May 1995 09:02:13 -0700
From: Poul-Henning Kamp <phk@ref.tfs.com>
Message-Id: <199505191602.JAA04882@ref.tfs.com>
Subject: Re: cvs commit: src/sys/i386/isa diskslice_machdep.c
To: bde@zeta.org.au (Bruce Evans)
Date: Fri, 19 May 1995 09:02:13 -0700 (PDT)
Cc: phk@freefall.cdrom.com, rgrimes@gndrsh.aac.dev.com,
        CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com
In-Reply-To: <199505190824.SAA23888@godzilla.zeta.org.au> from "Bruce Evans" at May 19, 95 06:24:23 pm
Content-Type: text
Content-Length: 786       
Sender: commit-owner@FreeBSD.org
Precedence: bulk

> >> phk         95/05/18 15:45:35
> >> 
> >>   Modified:    sys/i386/isa  diskslice_machdep.c
> >>   Log:
> >>   Make the "information" slice printfs if(bootverbose).
> >>   Fix the message about Ontrack.
> 
> >Reviewed by:????
> 
> Review: bootverbose is for controlling boots and should not be used in
> a routine that is called from open() and ioctl().  I suggest hiding
> the "OK" messages using TRACE(()) and printing the error messages if
> (dp->dp_typ == DOSPTYP_386BSD || dsi_debug).

bootverbose is for controlling kernel verbosity, and has the name because
it is settable from the boot prompt.

-- 
Poul-Henning Kamp <phk@login.dknet.dk> -- TRW Financial Systems, Inc.
'All relevant people are pertinent' && 'All rude people are impertinent'
=> 'no rude people are relevant'