From owner-cvs-src@FreeBSD.ORG Wed Oct 3 23:45:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEAC316A417; Wed, 3 Oct 2007 23:45:15 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id 950E813C45A; Wed, 3 Oct 2007 23:45:15 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l93NjDoX047099 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Wed, 3 Oct 2007 19:45:14 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Wed, 3 Oct 2007 16:48:00 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: John Baldwin In-Reply-To: <200710032106.l93L65bv095725@repoman.freebsd.org> Message-ID: <20071003164642.B615@10.0.0.1> References: <200710032106.l93L65bv095725@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 23:45:16 -0000 On Wed, 3 Oct 2007, John Baldwin wrote: > jhb 2007-10-03 21:06:05 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/fs/devfs devfs_vnops.c > sys/fs/fifofs fifo_vnops.c > sys/kern uipc_usrreq.c vfs_vnops.c > sys/vm vnode_pager.c > Log: > MFC: Always use an exclusive lock on the leaf vnode during an open() when > shared lookups are enabled. This closes a few races including a race where > concurrent opens of a fifo could result in different v_fifoinfo structures > in different threads. Long term we should really look for a better solution to this problem. There are a number of was to improve snapshots in ffs by fixing shared locking. > > Revision Changes Path > 1.114.2.15 +1 -0 src/sys/fs/devfs/devfs_vnops.c > 1.113.2.20 +1 -1 src/sys/fs/fifofs/fifo_vnops.c > 1.155.2.23 +1 -1 src/sys/kern/uipc_usrreq.c > 1.233.2.7 +2 -2 src/sys/kern/vfs_vnops.c > 1.221.2.9 +3 -3 src/sys/vm/vnode_pager.c >