From owner-dev-commits-src-main@freebsd.org Fri Jan 8 23:15:43 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8E504D9DB6 for ; Fri, 8 Jan 2021 23:15:43 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCJqf3rXbz3RFv for ; Fri, 8 Jan 2021 23:15:42 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1610147740; bh=hA5+tmSQJ7fNocva7wvbzR94N/49950xKwUl74YGdv2=; h=From:Subject:Date:To:From:Subject; b=UX0nTudDVQQlD4dy5i26Cb4WuPITYWvLpGyJgEFTaCusWgkqc87d+6mamwoIENfwK0iSnzrOT9PHRUdv0UCCLA2Piguf8XfnG5mPkZWOKt8x0csBLjw9zwIu1UQ8DPa2enifvTjdOjQFHetv2uuf5/2OOpwLr4LiAH0FLRuK+FoxmyCPgTcB3KE1zR3wKxtQB0h6ig95B0THDzUg9UTaUZItNtrTp8IkWVLDyu8RWaH3g26MO0lEmFB//N9pIauVlzKA3v1JsDKJrFDf92+tEsp4pUWuG9uLFSsIH3GMGvDpHNPddFTXRkf2VDU4PC1Ag3yxTe0WyYDaaZL7I5BKPg== X-YMail-OSG: JNyS5AUVM1mD8w67ikDA9tWktBIXqIr3C5Aj5TQtxZtQEvJAu9rqPbVbbGvDgIe 43NeTBSUfhYyhQwk92qfpyYN_qnlat5WFDgMWCHMqEZR3s1DcSAk040WQ0CC6UgjOrQ0F1GADkoX o1feHlHBw585Qvu6ojH_UbOEZBdtWpk_0pAMKRGA61sGYLudFnbpdDPjh1HzwpDdL5rXrHhzLEgY BpJD4gXLo5Y3VtOd8eGccaYabVhmEWmRK6iEu0pqgLQZyefmpkNzrJGrZfUH8jHrDV7LnnPk59OJ at0BKed_X5nWdyYXE7Xw_fGC2maaIGbnI58OaFnDb.p425k7QkIHqudlK0vsYjijQ6hEjBSyfoSY YREyFQk6pf4cvXxXYRRCYvJW7Ie9dri2RJ8olqk5XlGmGlgnMKHZ4jo02bsToEMDrvMm6gbni72Z u6AkQBULpa.hJf.6.ymnq_KBnfZXTxLfS_PFf8gn6jMJiA_WJXExKfxUSXXTh5BiUUz1QqIPaHzq wRWNI_n0_E14hdSWJxwV.ZU9O8fk9pCuA5UfOJDZSw73i8sET8ioP3VBCpy2T1s4LTx2TapDj3LP QPQgGpXzoSldrFagtR3JjRIHPyOczFpzFvEl.9rn3SxjCl3q0MLSPqYHQqt2rUJdpXTEZJTMRiks p2m9SA9XKq1WG889jWiWUVPbBMR7G56nvu7x_W1.JTkC6JfqSpV5MGHU_6dd9UOGEp1FY47NTGUc u7H7mM3UUbt7KD_o8Hor9Co_Pvnw189_LYjj3DOqJmJS6VS2Pb69c6imk6MUhi_1vVaadpKK7.T6 QxsdW.vbZb6YqogPckDdnmkStnb5NqPgeZzdW6q4zmteYjtHlWU34D_a4iiuy0RDNtj97x_uBj2r 67sv0v2B3G8AtUCHovhYS2xvyRfe1V_PBJSkS6tFNG9aLk2uZmYfvu1UvJTPv1I07qPqA2UTwLW_ HgqJ5ahbZk6YHQ8FpD45.tJ_n2t160PoKKrzMhxqtn1pvWEgiE6y3cquVWse6_mXJfS.Xx_C4OWi YuuT.uqmd2Ry4Cu28_bnaoaeExzc5CbRa5GTV.ft1UAAbZvQZwucHXHAlUAEUx7_LTOyXSHc0xYt 5M5XiioyWfWdGm3NUZZmTPjWqM_0DGT9bqFV0iGaS8NJOBpQDzRRZ_Af2Vn.NZ6XFuIfz4mfcdSD CSQbp9rfA7Q4TYWbk79e6h_qIGxeN9WwnNoLEjiUO6jCIQWIJzOJIxULJAZyJK2zo.4izlDqECuk n7oXVmQ2Exh8JjA.Borebo_JCzj8OeGN_2qfF_B.XTuzyEuze5.tPn2_N5PPvqLpOKNcrQQLY5yF y7LMEYxeviSCqNsv7RgM.YoebYDrGSxRWgXoTsUN9OAN0i1rXu3ufbI9Zk5usXUj6m8eYZhAYNpB DY3AgXD5aU1m1mZVC93Zv6_3yRpNiyzo76dB.Ls0rqW8d75p839.JqKILd3mht7YvFYns_DPVPY4 d2uFAd7y7EyFKZYobfno8JdXszgz4e9PKUwVmIrsE0FS83iaRdcBbL3_d_8672KLtmo3QXUzDx.7 lsfiaf18NjPtKIu_kMfq7uQm020aJZI8RiKA.6OkSM29lua6dEPNTkhSoju6cL1l.XMcLOOY5wLq eLN8GdXxQ.9eNyYtwTSEqdivsgupQjsgOnQaYE3NtJXLBi7vforbWkSw6N3ic4de94S.L_xb6PIF jR8IxjqJtMU2EjQRMYDcgw3wBdeSr907vAMda2h7k0CllYk2hqTVQN9yTY866kLvydnsH5TKp7ia Q4vsecFHhQWSZFUaanf9NPzpONZz4hQMgLLvHH7blCu_Ux.oBp_O3EJFJH9wDhUYyMbMg5LTDyfB DdvBQ4gQOqd66Cbm3daoUxgQVINGp4hI.2C.n9MoMoV11bigEK..RIozx75ZY2It9K0xzNmVL9B. Jh_tnWS9UiWSlmAvTY53af8OzVKo2lHDSZnPCnNaiG7Wk.fIXlDoZMHF3rFFD0GFRWypxdrIdEnI 6i0w9Rm4_QR4Ntc4.NdlMEj.Yj1.xJL1SmwKASDTk_RjW_KA_YHjgvWGp5jpLech7lSbWMkg1lAM dAUZnupTCLDNoXkSdqPjZ_8.THroD1E9HEIRMtD2HzPrqTniNARSYSesvLnqbSc3MwSwURgUsHxL JnARpKOBpvb8pBGHzGcghfOMp_a4Su6XsN8Pt39M8EZleau9vQjDihZQn9mCMQzrGEs5RmsJvmur pY9zFRGoLSttjXWd6txCbOyo8jGHdkDbgwOtzA1Nk4KFYh9Di_yNEkQrJe6ooZrORQEznc8Hntok 585d1ZpAHd3ktcq.DS78MUVv3QI5O3F3O8hCQN9BCmBsOhiUcNsZvwCF3tAc70GWr.M6pdXvPK80 up36yfsShmvk.ynDA996IhJ.2QDEXD80S57mEK2OCnGl1wp_q1yX9ZnAWhKM9ezACA_dSh_0lcMd SHpwHI3bMb5kUAmelDFs7oHujT_YkACTRAaoc90Wz4TEIQ6MwxAh4TmZGoMMr0Pt4G46Katw0l08 ik1TCp6L6O.O_kdbSB4tggLp03Ww4KQ-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Fri, 8 Jan 2021 23:15:40 +0000 Received: by smtp408.mail.bf1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 2d9107497ea78854e25a2514c87245c1; Fri, 08 Jan 2021 23:15:37 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: git: a82f07fc2e24 - main - Fix 32-bit build post 6733401935f83754b4b2744bc3d33ef84b1271e0 Message-Id: <7BAE448B-2C76-4EE8-B64F-9949E078CE54@yahoo.com> Date: Fri, 8 Jan 2021 15:15:35 -0800 To: Dimitry Andric , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3654.40.0.2.32) References: <7BAE448B-2C76-4EE8-B64F-9949E078CE54.ref@yahoo.com> X-Rspamd-Queue-Id: 4DCJqf3rXbz3RFv X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[98.137.65.31:from]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[98.137.65.31:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.31:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.31:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 23:15:43 -0000 Dimitry Andric dim at FreeBSD.org wrote on Fri Jan 8 22:39:16 UTC 2021 : > . . . > The general style in sbin/nvmecontrol apppears to print uint64_t types > using %j, so I'm using that instead of the more general (but admittedly > ugly) PRIu64. > . . . > - printf(" FLBA=0x%lx", failing_lba); > + printf(" FLBA=0x%jx", failing_lba); > . . . %jx is for uintmax_t values on the stack, which may have more bits than uint64_t would. It looks to me like a (uintmax_t) cast is missing to make sure that the format specifier and value on the stack agree about the memory use. (FreeBSD seems to have standardized on %jx and %jd and such, mixed with the matching cast to uintmax_t or intmax_t for handling the varying sizes across platforms. At least I've seen a lot of examples of such code in the past.) === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)