From owner-freebsd-current Mon Feb 18 23:12:28 2002 Delivered-To: freebsd-current@freebsd.org Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by hub.freebsd.org (Postfix) with ESMTP id C2F5637B404 for ; Mon, 18 Feb 2002 23:12:21 -0800 (PST) Received: from peter3.wemm.org ([12.232.27.13]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020219071219.TXQK2626.rwcrmhc51.attbi.com@peter3.wemm.org> for ; Tue, 19 Feb 2002 07:12:19 +0000 Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id g1J7CEs35749 for ; Mon, 18 Feb 2002 23:12:14 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id B21BE3A9A; Mon, 18 Feb 2002 23:12:14 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Matthew Dillon Cc: current@FreeBSD.ORG Subject: Re: Patch sets to date and timing tests with Giant out of userret. In-Reply-To: <20020219070403.B151F3A9A@overcee.wemm.org> Date: Mon, 18 Feb 2002 23:12:14 -0800 From: Peter Wemm Message-Id: <20020219071214.B21BE3A9A@overcee.wemm.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Peter Wemm wrote: > Matthew Dillon wrote: > > :> - mtx_lock(&Giant); > > :> - td->td_retval[0] = p->p_ucred->cr_ruid; > > :> + s = mtx_lock_giant(kern_giant_ucred); > > :> + td->td_retval[0] = td->td_ucred->cr_ruid; > > :> #if defined(COMPAT_43) || defined(COMPAT_SUNOS) > > :> - td->td_retval[1] = p->p_ucred->cr_uid; > > :> + td->td_retval[1] = td->td_ucred->cr_uid; > > :> #endif > > :> - mtx_unlock(&Giant); > > :> + mtx_unlock_giant(s); > > :> return (0); > > : > > :What a waste.. John has already done all this stuff already (using > > :td_ucred instead of p_ucred) over the entire tree. > > : > > :Cheers, > > :-Peter > > > > He didn't instrument Giant, and if you actually believe that one > > massive commit is going to be more stable then the piecemeal safe-mode > > commits I am making then you are smoking something. Or are you > > expecting John to commit his patchset piecemeal as well and test > > inbetween? If that is so, then he just wasted a whole lot time > > managing all this junk in P4 because, frankly, it only took me a few > > minutes to instrument the easier system calls. I spend far more > > time testing. > > So, John's last few months of work is junk then, is it? I looked up john's version of this: @ -228,14 +228,11 @@ struct thread *td; struct getuid_args *uap; { - struct proc *p = td->td_proc; - mtx_lock(&Giant); - td->td_retval[0] = p->p_ucred->cr_ruid; + td->td_retval[0] = td->td_ucred->cr_ruid; #if defined(COMPAT_43) || defined(COMPAT_SUNOS) - td->td_retval[1] = p->p_ucred->cr_uid; + td->td_retval[1] = td->td_ucred->cr_uid; #endif - mtx_unlock(&Giant); return (0); } That has exactly the same change that you made, with regards to p_ucred/td_ucred. Regarding the instrumentation of Giant for *trivial* stuff like this: I'm one of the people you called "bozos" that disagrees with you about the usefulness of bloating the source with this stuff that only needs to be removed again later. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message