Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Feb 2013 21:20:01 GMT
From:      Martin Tournoij <martin@arp242.net>
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/175976: [patch] Install desktop icon for games/boswars
Message-ID:  <201302092120.r19LK1x6045618@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/175976; it has been noted by GNATS.

From: Martin Tournoij <martin@arp242.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/175976: [patch] Install desktop icon for games/boswars
Date: Sat, 9 Feb 2013 22:17:53 +0100

 On Sat, Feb 09, 2013 at 04:20:07AM +0000, Edwin Groothuis wrote:
 > Maintainer of games/boswars,
 > 
 > Please note that PR ports/175976 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/175976
 > 
 > -- 
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 
 Thank you Kevin. I don't use a desktop environment, so I never noticed the
 broken icon :-/
 
 As for the portlint error, I don't see any (?)
 
 [/home/martin/boswars]# portlint -A
 WARN: Makefile: [30]: possible direct use of command "false" found. use ${FALSE} instead.
 WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
 WARN: Makefile: new ports should not set PORTREVISION.
 WARN: Makefile: only one MASTER_SITE configured.  Consider adding additional mirrors.
 0 fatal errors and 4 warnings found.
 
 [/home/martin/boswars]# portlint -V
 portlint version 2.13.13
 
 
 In any case, this patch looks OK.
 
 
 -- 
 Martin Tournoij <martin@arp242.net>
 http://arp242.net | http://daemonforums.org
 
 QOTD:
 HELP!  MY TYPEWRITER IS BROKEN!
 		-- E. E. CUMMINGS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302092120.r19LK1x6045618>