Date: Sat, 25 Jul 2009 05:34:33 +0400 From: Anonymous <swell.k@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/137114: [patch] x11/babl: add SIMD knob Message-ID: <86fxcl4kba.fsf@gmail.com> Resent-Message-ID: <200907250140.n6P1e3xK045917@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 137114
>Category: ports
>Synopsis: [patch] x11/babl: add SIMD knob
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Jul 25 01:40:03 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Anonymous
>Release: FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD luffy 8.0-BETA2 FreeBSD 8.0-BETA2 #0 r195826M: Wed Jul 22 20:12:21 UTC 2009 root@luffy:/usr/obj/usr/src/sys/PHOENIX amd64
>Description:
Enable use of SIMD optimizations. Off by default and autodetected otherwise.
At least they don't break gimp and gegl.
While here, fix mktemp(1) invocation in docs/Makefile.in so it no longer
produces confusing usage string during build.
gmake[2]: Entering directory `/usr/ports/x11/babl/work/babl-0.0.22/docs'
Making all in graphics
UTF8: BablFishPath.txt [OK]
HTML: index.htmlusage: mktemp [-d] [-q] [-t prefix] [-u] template ...
mktemp [-d] [-q] [-u] -t prefix
. [OK]
HTML: BablFishPath.html [OK]
RSS: changelog.rss [OK]
gmake[2]: Leaving directory `/usr/ports/x11/babl/work/babl-0.0.22/docs'
>How-To-Repeat:
$ make config (select SIMD)
$ make configure
[...]
checking for some Win32 platform... checking for some Win32 platform... no
checking for native Win32... no
checking whether cc understands -mmmx... yes
checking whether we can compile MMX code... yes
checking whether cc understands -msse... yes
checking whether we can compile SSE code... yes
checking whether cc understands -faltivec... no
checking whether cc understands -maltivec -mabi=altivec... no
checking whether we can compile AltiVec code... no
configure: WARNING: The compiler does not support the AltiVec command set.
checking for library containing dlopen... none required
[...]
Notice that AltiVec is NOT enabled even though --enable-altivec
was specified.
>Fix:
--- babl.diff begins here ---
Index: x11/babl/Makefile
===================================================================
RCS file: /home/csup/ports/x11/babl/Makefile,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile
--- x11/babl/Makefile 28 Oct 2008 04:13:30 -0000 1.4
+++ x11/babl/Makefile 25 Jul 2009 01:20:39 -0000
@@ -27,4 +27,14 @@ USE_AUTOTOOLS= libtool:15
USE_GNOME= pkgconfig gnomehack ltverhack
USE_GMAKE= yes
-.include <bsd.port.mk>
+OPTIONS= SIMD "Use cpu-specific optimizations if available" off
+
+.include <bsd.port.pre.mk>
+
+.if !defined(WITHOUT_SIMD)
+CONFIGURE_ARGS+=--enable-mmx \
+ --enable-sse \
+ --enable-altivec
+.endif
+
+.include <bsd.port.post.mk>
Index: x11/babl/files/patch-docs-Makefile.in
===================================================================
RCS file: x11/babl/files/patch-docs-Makefile.in
diff -N x11/babl/files/patch-docs-Makefile.in
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ x11/babl/files/patch-docs-Makefile.in 25 Jul 2009 01:06:15 -0000
@@ -0,0 +1,11 @@
+--- docs/Makefile.in~
++++ docs/Makefile.in
+@@ -571,7 +571,7 @@ index.html: index-static.html
+ Makefile.am
+ echo -n "HTML: $@"
+ cp $< $@
+- (which mktemp > /dev/null&& TMPFILE=`mktemp` || TMPFILE="/tmp/babl_build_tempfile" ;\
++ (which mktemp > /dev/null&& TMPFILE=`mktemp -t babl` || TMPFILE="/tmp/babl_build_tempfile" ;\
+ export BABL_PATH="$(top_builddir)/extensions"; $(babl_html_dump) > $$TMPFILE;\
+ $(top_srcdir)/docs/tools/xml_insert.sh $@ BablBase $$TMPFILE;\
+ rm -f $$TMPFILE )
--- babl.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86fxcl4kba.fsf>