From owner-p4-projects@FreeBSD.ORG  Thu Jul 29 19:56:33 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 12C8E16A4D1; Thu, 29 Jul 2004 19:56:33 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DD64616A4CE
	for <perforce@freebsd.org>; Thu, 29 Jul 2004 19:56:32 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D4F7343D68
	for <perforce@freebsd.org>; Thu, 29 Jul 2004 19:56:32 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i6TJu33C053414
	for <perforce@freebsd.org>; Thu, 29 Jul 2004 19:56:03 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i6TJu3Ux053411
	for perforce@freebsd.org; Thu, 29 Jul 2004 19:56:03 GMT
	(envelope-from jhb@freebsd.org)
Date: Thu, 29 Jul 2004 19:56:03 GMT
Message-Id: <200407291956.i6TJu3Ux053411@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 58479 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2004 19:56:33 -0000

http://perforce.freebsd.org/chv.cgi?CH=58479

Change 58479 by jhb@jhb_slimer on 2004/07/29 19:55:07

	Properly move gcc membar before the store.
	
	Submitted by: gibbs

Affected files ...

.. //depot/projects/smpng/sys/i386/include/atomic.h#15 edit

Differences ...

==== //depot/projects/smpng/sys/i386/include/atomic.h#15 (text+ko) ====

@@ -190,8 +190,8 @@
 static __inline void					\
 atomic_store_rel_##TYPE(volatile u_##TYPE *p, u_##TYPE v)\
 {							\
+	__asm __volatile("" : : : "memory");		\
 	*p = v;						\
-	__asm __volatile("" : : : "memory");		\
 }							\
 struct __hack
 
@@ -214,8 +214,8 @@
 static __inline void					\
 atomic_store_rel_##TYPE(volatile u_##TYPE *p, u_##TYPE v)\
 {							\
+	__asm __volatile("" : : : "memory");		\
 	*p = v;						\
-	__asm __volatile("" : : : "memory");		\
 }							\
 struct __hack