Date: Thu, 20 May 2004 17:21:27 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Luigi Rizzo <rizzo@icir.org> Cc: andre@freebsd.org Subject: Re: ia_netbroadcast Message-ID: <20040520152127.GP845@darkness.comp.waw.pl> In-Reply-To: <20040518034756.A9648@xorpc.icir.org> References: <20040518092439.GF845@darkness.comp.waw.pl> <20040518024346.A5068@xorpc.icir.org> <20040518100503.GG845@darkness.comp.waw.pl> <20040518034756.A9648@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nzBWqDnK1U3UjuAj Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 18, 2004 at 03:47:56AM -0700, Luigi Rizzo wrote: +> On Tue, May 18, 2004 at 12:05:03PM +0200, Pawel Jakub Dawidek wrote: +> ... +> > +> > Do we still need ia_netboradcast field? It is calculated dependin= g on +> > +> > old-fashion classes (A, B, C). Is it used still? +> > +> > I wonder if ia_broadaddr isn't sufficient today. +> > +>=20 +> > +> not just that, it seems that ia_netboradcast contains bogus info. +> >=20 +> > So? +>=20 +> nuke it! +> Also if, as Andre said, it might be used by windows apps, +> one could certainly compute it on the fly from the IP address. Ok, this patch: http://people.freebsd.org/~pjd/patches/no_old_style_nets.patch removes ia_netbroadcast, ia_net, ia_netmask field from structure in_ifaddr and removes sysctl net.inet.ip.subnets_are_local as suggested in commit log of revision 1.24 of file netinet/in.c: Set subnetsarelocal to false. In a classless world, the other case is almost never useful. (This is only a quick hack; someone should go back and delete the entire subnetsarelocal=3D=3D1 code path.) Tests and comments are welcome. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --nzBWqDnK1U3UjuAj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFArMz3ForvXbEpPzQRAriuAJ0WR07PWsqzQjyU5hUoEGLA1Ap9pACfftLx xUmWdjrNsdJZVuD5/Cqa1Ac= =TBGN -----END PGP SIGNATURE----- --nzBWqDnK1U3UjuAj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040520152127.GP845>