From owner-freebsd-bugs@FreeBSD.ORG Sun Mar 21 07:11:35 2010 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29709106566C for ; Sun, 21 Mar 2010 07:11:35 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id F18E38FC08 for ; Sun, 21 Mar 2010 07:11:34 +0000 (UTC) Received: by pvc7 with SMTP id 7so1090083pvc.13 for ; Sun, 21 Mar 2010 00:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=gubZxWbet8uRDR9393mUdKOcxLdjd+iA/Dw1vjHEgtI=; b=snKIILsT2Wg+NOXBdrLcZqQAXExK1JCnk1Bl0s93/X3cvjsvsJyIX1KmONi4aby9lO sDxxz4peyae6rgew5u/qzPVcK+9K03OCiSzzVVjTiPM0IHN8dlLWyIT0Ep9UNxMHNWEL 9dS1ViqXrx1BNDPQWNN8N+OTsbD2oAFxi4BsI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=nupCulxrHeeDANcLdtaUDw3ZrvfKUkhr+sxzRHVLoGWdit0arFw7KWbOz9jRNmMI28 gozzmI8Jh5zLPHIperPtUd2dMTAy8eTrQU12G3WtoBOt1qFdndKuLWTv6mnjrMWLFecm S4NvlqOTrSlU3QjXNzQIqOJNmbnMjh3LdX8vk= MIME-Version: 1.0 Received: by 10.142.152.34 with SMTP id z34mr831559wfd.176.1269155493624; Sun, 21 Mar 2010 00:11:33 -0700 (PDT) In-Reply-To: <201003210650.o2L6o6Ih085240@freefall.freebsd.org> References: <201003210650.o2L6o6Ih085240@freefall.freebsd.org> Date: Sun, 21 Mar 2010 00:11:33 -0700 Message-ID: <7d6fde3d1003210011g40a93fb2l5f8544d4c2d35061@mail.gmail.com> From: Garrett Cooper To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-bugs@freebsd.org, Efstratios Karatzas Subject: Re: bin/139606: [patch] pkg_add(1) coredumps silently on atlantis symlink X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Mar 2010 07:11:35 -0000 On Sat, Mar 20, 2010 at 11:50 PM, Garrett Cooper wrote= : > The following reply was made to PR bin/139606; it has been noted by GNATS= . > > From: Garrett Cooper > To: bug-followup@FreeBSD.org, phk@critter.freebsd.dk > Cc: > Subject: Re: bin/139606: [patch] pkg_add(1) coredumps silently on atlanti= s > =A0 =A0 =A0 =A0symlink > Date: Sat, 20 Mar 2010 23:44:06 -0700 > > =A0Hi PHK, > =A0 =A0 The goals of this change are good and while this does do a better > =A0job than the other proposed change (bin/136419), there's one solitary > =A0problem: fexists is used all over the pkg_install code and minus the > =A0occasional corner case it's been relatively glitch free. Changing this > =A0code to use stat(2) instead of lstat(2) may have some unexpected > =A0consequences -- it would probably just be a wiser idea to 1) leave the > =A0code alone with the issue documented or 2) implement stat(2) in that > =A0section of code, because we know it's a problem section of code that > =A0needs to be resolved. Not doing this will result in potential > =A0regressive churn if it hasn't been adequately tested with a fine tooth > =A0comb. 1. PHK didn't post the reply; Efstratios did (sorry PKH ><). 2. There wasn't actually a solution suggested in the other PR. Thanks, -Garrett