Date: Sun, 21 Mar 2010 00:11:33 -0700 From: Garrett Cooper <yanefbsd@gmail.com> To: Garrett Cooper <yanegomi@gmail.com> Cc: freebsd-bugs@freebsd.org, Efstratios Karatzas <gpf.kira@gmail.com> Subject: Re: bin/139606: [patch] pkg_add(1) coredumps silently on atlantis symlink Message-ID: <7d6fde3d1003210011g40a93fb2l5f8544d4c2d35061@mail.gmail.com> In-Reply-To: <201003210650.o2L6o6Ih085240@freefall.freebsd.org> References: <201003210650.o2L6o6Ih085240@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 20, 2010 at 11:50 PM, Garrett Cooper <yanegomi@gmail.com> wrote= : > The following reply was made to PR bin/139606; it has been noted by GNATS= . > > From: Garrett Cooper <yanegomi@gmail.com> > To: bug-followup@FreeBSD.org, phk@critter.freebsd.dk > Cc: > Subject: Re: bin/139606: [patch] pkg_add(1) coredumps silently on atlanti= s > =A0 =A0 =A0 =A0symlink > Date: Sat, 20 Mar 2010 23:44:06 -0700 > > =A0Hi PHK, > =A0 =A0 The goals of this change are good and while this does do a better > =A0job than the other proposed change (bin/136419), there's one solitary > =A0problem: fexists is used all over the pkg_install code and minus the > =A0occasional corner case it's been relatively glitch free. Changing this > =A0code to use stat(2) instead of lstat(2) may have some unexpected > =A0consequences -- it would probably just be a wiser idea to 1) leave the > =A0code alone with the issue documented or 2) implement stat(2) in that > =A0section of code, because we know it's a problem section of code that > =A0needs to be resolved. Not doing this will result in potential > =A0regressive churn if it hasn't been adequately tested with a fine tooth > =A0comb. 1. PHK didn't post the reply; Efstratios did (sorry PKH ><). 2. There wasn't actually a solution suggested in the other PR. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d1003210011g40a93fb2l5f8544d4c2d35061>